1961480 - Testcase converting Day from Instant in Temporal spends a lot of time around MinorGC (N=5000000)

Status: VERIFIED FIXED

(Core :: JavaScript: Internationalization API, task, P3)

Description

[Mayank Bansal]

Open the testcase

Instant inside the loop
N=5000000

• Firefox: https://share.firefox.dev/3Gc5N3d (10s)
• Chrome: Temporal not supported

Instant outside the loop
N=5000000

• Firefox: https://share.firefox.dev/4jlg8sv (9s)
• Chrome: Temporal not supported

Not the most perf-critical, but maybe something to improve here?

Comment 1

[André Bargull [:anba]]

The test case is missing.

Comment 2

[Mayank Bansal]

Attachment: Temporal Day from Instant.html

Comment 3

[Mayank Bansal]

Latest profile: https://share.firefox.dev/4lBXzBz (1.5s)

Comment 4

[André Bargull [:anba]]

I think the profile is now looking more reasonable. There are some tiny things which maybe could be improved, but I don't think it's currently worthwhile to optimise for this µ-benchmark. I guess we can close this as fixed through the changes from bug 1840424.

Comment 5

[Mayank Bansal]

Thanks :anba for fixing this!