1961755 - TenuredCell::markIfUnmarkedAtomic method is misnamed

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P5)

Description

[Jon Coppeard (:jonco)]

This method is thread safe but may return false positives as explained in the comment here: https://searchfox.org/mozilla-central/source/js/src/gc/Heap-inl.h#127-129

So although this is thread safe but the name 'atomic' is a bit misleading. We could rename this and then add an actual atomic version for the occasions this would be useful.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1961755 - Rename markIfUnmarkedAtomic methods to markIfUnmarkedThreadSafe r?sfink

These methods may return false positives so are not really atomic. Thread-safe
is a better description.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1182570637cc
Rename markIfUnmarkedAtomic methods to markIfUnmarkedThreadSafe r=sfink

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1182570637cc