1961874 - Use Intl.ListFormat for netmonitor waterfall tooltip

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task)

Description

[Eemeli Aro [:eemeli]]

Currently, we're requiring localisers to specify a list item delimiter specifically for this string, including an escaped trailing space for many locales. We should rather use Intl.ListFormat, which already has the required data.

Comment 1

[Eemeli Aro [:eemeli]]

I put together a small patch for this, but I can't find a way to verify it -- is the devtools/client/netmonitor/src/components/request-list/RequestListColumnWaterfall.js component actually used any more, or has it been replaced by the new profiler?

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: tooltip

Hello eemeli, thanks for looking into this
There's actually a typo in this component that prevents the code you're modifying to be reached.
Applying the following diff, I can see that the localized string is being hit, and hovering the timing bar does show the result of timingTooltip (see screenshot)

diff --git a/devtools/client/netmonitor/src/components/request-list/RequestListColumnWaterfall.js b/devtools/client/netmonitor/src/components/request-list/RequestListColumnWaterfall.js
--- a/devtools/client/netmonitor/src/components/request-list/RequestListColumnWaterfall.js
+++ b/devtools/client/netmonitor/src/components/request-list/RequestListColumnWaterfall.js
@@ -183,7 +183,7 @@ module.exports = class RequestListColumn
     return dom.td(
       {
         className: "requests-list-column requests-list-waterfall",
-        onMouseOver: this.handeMouseOver,
+        onMouseOver: this.handleMouseOver,
       },
       div(
         {

Let us know if you have any other question

Comment 3

[Eemeli Aro [:eemeli]]

Attachment: Bug 1961874 - Use Intl.ListFormat for netmonitor waterfall tooltip. r?nchevobbe!

Comment 4

[Eemeli Aro [:eemeli]]

Ah, that does explain things. With that (now included in the patch) I could see my change working locally.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdcfbd0f2e5a
Use Intl.ListFormat for netmonitor waterfall tooltip. r=nchevobbe,devtools-reviewers

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/fdcfbd0f2e5a