1961895 - [wpt-sync] Sync PR 52048 - Prevent composited ref filter with empty ref box from optimizing away

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 52048 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52048
Details from upstream follow.

Sam Fortiner <[e-mail]> wrote:

Prevent composited ref filter with empty ref box from optimizing away

There are multiple places in the composition layer and layer to render
pass pipeline that make assumptions that an empty layer does not
contribute to the final rendered output. However, an empty composited
div with a reference filter can contribute to the rendered output. This
fix modifies several of those early-outs to avoid bailing if a reference
filter is present.

RenderSurfaceImpl::AppendQuads - would not add a a quad if the
unoccluded_output_rect was empty.

LayerNeedsUpdate - (used by both UI and CC trees) would prevent layer
updates if the layer->bounds() was empty. Similarly,
ComputeListOfNonEmptySurfaces would remove any surface with an empty
content rect. Both of these would cause the surface list to exclude the
surface for the filter, which would eventually cause the render pass to
be missing for the filter.

This change loosens these checks to allow the presence of a reference
filter to bypass them.

Note that if AllowSkipEmptyNonrootRenderPassDraws is disabled, this
change can lead to both HW and SW rendering crashing. But that flag has
been enabled by default for almost a year and is expected to be removed
in the near future.

Also note that this change is dependent on http://crrev.com/1444153.
Without that fix, SW rendering will still fail to draw the filter
content.

Bug: 40694530
Change-Id: I20df2cd920dbf5a1b78270d733124d16701d3fa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6378573
Reviewed-by: Vladimir Levin \<[e-mail]>
Reviewed-by: Vasiliy Telezhnikov \<[e-mail]>
Commit-Queue: Sam Fortiner \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1448602}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=37a1a54b826d06bcf426eb5001b9dbf270bcca6a

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/215331ab3767
[wpt PR 52048] - Prevent composited ref filter with empty ref box from optimizing away, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/215331ab3767