1961909 - Remove usage of six in tools/ directory

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, task, P3)

Comment 1

[[:anutrix]]

I will work on this.

Comment 2

[[:anutrix]]

I will exclude removing six from tools\fuzzing\smoke\grizzly_requirements.txt as that needs a changes upstream. I think it should ideally be moved to third-party directory. See https://github.com/MozillaSecurity/grizzly/issues/495.

---

Additionally, tools\lint\hooks_clang_format.py changes aren't direct:

• Initally, six was added to it because it used mozversioncontrol that used mozfile.
• mozversioncontrol doesn't use python/mozbuild since https://phabricator.services.mozilla.com/D119905 . I removed it but let me if you want me to keep it.
• mozfile only installed it in testing\mozbase\mozfile\setup.py but there's no phabricator link except https://bugzilla.mozilla.org/show_bug.cgi?id=1388018 . All six usage in testing\mozbase\mozfile now seems gone already.

I don't have clang-format hook and python-hglib on my machine and I work set it up through git-cinnabar. It would helpful experienced with hg would test the changes for that file.
Do advice if there's specific tests to run.

Comment 3

[[:anutrix]]

Attachment: Bug 1961909 - Removed usage of six in tools directory and removed six from mozfile's setup.py. r=#build

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8633a5fcd0a0
Removed usage of six in tools directory and removed six from mozfile's setup.py. r=firefox-build-system-reviewers,perftest-reviewers,ahochheiden,fbilt

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8633a5fcd0a0