Closed Bug 1961941 Opened 26 days ago Closed 24 days ago

[wpt-sync] Sync PR 52079 - [Gap Decorations]: Parse rule-style shorthand

Tracking

()

Status:

RESOLVED FIXED

Milestone:

139 Branch

Tracking Flags:

Tracking

Status

firefox139

---

fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

26 days ago

Sync web-platform-tests PR 52079 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52079
Details from upstream follow.

Sam Davis Omekara <samomekarajr@microsoft.com> wrote:

[Gap Decorations]: Parse rule-style shorthand

This CL implements the rule style bi-directional shorthand which sets
the column-rule-style and row-rule-style to the same value.

See: https://drafts.csswg.org/css-gaps-1/#propdef-rule-style

Bug: 357648037
Change-Id: Iadfcd3bbd82d4fd390e8109364cb44cc5a0ed870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6418570
Reviewed-by: Alison Maher \<almaher@microsoft.com>
Reviewed-by: Kevin Babbitt \<kbabbitt@microsoft.com>
Commit-Queue: Sam Davis Omekara \<samomekarajr@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1449611}

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

26 days ago

PR 52079 applied with additional changes from upstream: 53919a39fcb07a658fe71062d05bcec0e1298181, 011a87430c6f7b1b4fd7e825135330a82c4b3612

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

26 days ago

Component: web-platform-tests → CSS Parsing and Computation

Product: Testing → Core

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

26 days ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2cefbe51d0f2bd322c5bf5eb1a6539a92f516934

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 3

•

25 days ago

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 45 subtests

Status Summary

Firefox

OK : 4
PASS: 31
FAIL: 101[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 103[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt, GitHub]

Chrome

OK : 4
PASS: 31
FAIL: 103

Safari

OK : 4
PASS: 31
FAIL: 103

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-gaps/tentative/flex/flex-gap-decorations-019.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-gaps/tentative/grid/grid-gap-decorations-022.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-gaps/tentative/parsing/gap-decorations-bidirectional-shorthands.html [wpt.fyi]
- rule-color shorthand computed from longhand values: FAIL (Chrome: FAIL, Safari: FAIL)
- rule-width shorthand computed from longhand values: FAIL (Chrome: FAIL, Safari: FAIL)
- rule-style shorthand computed from longhand values: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-gaps/tentative/parsing/gap-decorations-style-computed.html [wpt.fyi]
- Property column-rule-style value 'dotted dashed solid': FAIL (Chrome: FAIL, Safari: FAIL)
- Property column-rule-style value 'repeat(10, double)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property column-rule-style value 'repeat(3, groove) repeat(4, ridge)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property column-rule-style value 'repeat(auto, solid)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property column-rule-style value 'repeat(auto, dotted solid inset)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property column-rule-style value 'repeat(4, none ridge solid) repeat(auto, hidden)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property column-rule-style value 'inset repeat(auto, solid ridge) repeat(4, none groove hidden)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property column-rule-style value 'repeat(calc(5 + 3), ridge)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property column-rule-style value 'repeat(4, dotted double dashed) repeat(auto, solid) ridge': FAIL (Chrome: FAIL, Safari: FAIL)
- Property column-rule-style value 'repeat(4, dotted double dashed) repeat(auto, solid) repeat(4, none groove hidden)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property column-rule-style value 'ridge repeat(auto, solid)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property column-rule-style value 'ridge repeat(auto, solid) ridge': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'none': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'hidden': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'dotted': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'dashed': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'solid': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'double': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'groove': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'ridge': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'inset': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'dotted dashed solid': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'repeat(10, double)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'repeat(3, groove) repeat(4, ridge)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'repeat(auto, solid)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'repeat(auto, dotted solid inset)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'repeat(4, none ridge solid) repeat(auto, hidden)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'inset repeat(auto, solid ridge) repeat(4, none groove hidden)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'repeat(calc(5 + 3), ridge)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'repeat(4, dotted double dashed) repeat(auto, solid) ridge': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'repeat(4, dotted double dashed) repeat(auto, solid) repeat(4, none groove hidden)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'ridge repeat(auto, solid)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property row-rule-style value 'ridge repeat(auto, solid) ridge': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'none': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'hidden': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'dotted': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'dashed': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'solid': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'double': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'groove': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'ridge': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'inset': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'dotted dashed solid': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'repeat(10, double)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'repeat(3, groove) repeat(4, ridge)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'repeat(auto, solid)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'repeat(auto, dotted solid inset)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'repeat(4, none ridge solid) repeat(auto, hidden)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'inset repeat(auto, solid ridge) repeat(4, none groove hidden)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'repeat(calc(5 + 3), ridge)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'repeat(4, dotted double dashed) repeat(auto, solid) ridge': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'repeat(4, dotted double dashed) repeat(auto, solid) repeat(4, none groove hidden)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'ridge repeat(auto, solid)': FAIL (Chrome: FAIL, Safari: FAIL)
- Property rule-style value 'ridge repeat(auto, solid) ridge': FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-gaps/tentative/parsing/gap-decorations-style-valid.html [wpt.fyi]
- e.style['column-rule-style'] = "repeat(4, dotted)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['column-rule-style'] = "repeat(3, dashed double dotted)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['column-rule-style'] = "repeat(1, dashed double dotted solid)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['column-rule-style'] = "repeat(4, double)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['column-rule-style'] = "dotted ridge" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['column-rule-style'] = "dotted dashed solid groove ridge" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['column-rule-style'] = "repeat(3, groove) repeat(4, ridge)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['column-rule-style'] = "inset repeat(3, ridge) none repeat(4, groove hidden dashed)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['column-rule-style'] = "repeat(4, none ridge solid) repeat(5, hidden) double" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['column-rule-style'] = "repeat(auto, solid)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['column-rule-style'] = "repeat(auto, dotted solid inset)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['column-rule-style'] = "repeat(auto, dashed groove) ridge" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['column-rule-style'] = "repeat(4, dotted double dashed) repeat(auto, solid)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['column-rule-style'] = "inset repeat(auto, solid ridge) repeat(4, none groove hidden)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['row-rule-style'] = "repeat(4, dotted)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['row-rule-style'] = "repeat(3, dashed double dotted)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['row-rule-style'] = "repeat(1, dashed double dotted solid)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['row-rule-style'] = "dashed" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['row-rule-style'] = "repeat(4, double)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['row-rule-style'] = "dotted ridge" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['row-rule-style'] = "dotted dashed solid groove ridge" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['row-rule-style'] = "repeat(3, groove) repeat(4, ridge)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['row-rule-style'] = "inset repeat(3, ridge) none repeat(4, groove hidden dashed)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['row-rule-style'] = "repeat(4, none ridge solid) repeat(5, hidden) double" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['row-rule-style'] = "repeat(auto, solid)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['row-rule-style'] = "repeat(auto, dotted solid inset)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['row-rule-style'] = "repeat(auto, dashed groove) ridge" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['row-rule-style'] = "repeat(4, dotted double dashed) repeat(auto, solid)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['row-rule-style'] = "inset repeat(auto, solid ridge) repeat(4, none groove hidden)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['rule-style'] = "repeat(4, dotted)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['rule-style'] = "repeat(3, dashed double dotted)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['rule-style'] = "repeat(1, dashed double dotted solid)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['rule-style'] = "dashed" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['rule-style'] = "repeat(4, double)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['rule-style'] = "dotted ridge" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['rule-style'] = "dotted dashed solid groove ridge" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['rule-style'] = "repeat(3, groove) repeat(4, ridge)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['rule-style'] = "inset repeat(3, ridge) none repeat(4, groove hidden dashed)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['rule-style'] = "repeat(4, none ridge solid) repeat(5, hidden) double" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['rule-style'] = "repeat(auto, solid)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['rule-style'] = "repeat(auto, dotted solid inset)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['rule-style'] = "repeat(auto, dashed groove) ridge" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['rule-style'] = "repeat(4, dotted double dashed) repeat(auto, solid)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['rule-style'] = "inset repeat(auto, solid ridge) repeat(4, none groove hidden)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

24 days ago

Depends on: 1962277

Pulsebot

Comment 4

•

24 days ago

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/707c31cbbd06 [wpt PR 52079] - [Gap Decorations]: Parse rule-style shorthand, a=testonly https://hg.mozilla.org/integration/autoland/rev/30be0d97beb6 [wpt PR 52079] - Update wpt metadata, a=testonly

Sandor Molnar[:smolnar]

Comment 5

•

24 days ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/707c31cbbd06
https://hg.mozilla.org/mozilla-central/rev/30be0d97beb6

Status: NEW → RESOLVED

Closed: 24 days ago

status-firefox139: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 139 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

[wpt-sync] Sync PR 52079 - [Gap Decorations]: Parse rule-style shorthand

Categories

(Core :: CSS Parsing and Computation, task, P4)

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Comment 1

Updated

Comment 2

Comment 3

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

Updated

Comment 4

Comment 5