1962004 - [wpt-sync] Sync PR 52105 - Add connectedness/activity check for IsOpen for dialogs

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 52105 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52105
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Add connectedness/activity check for IsOpen for dialogs

Many such checks of IsOpen() implicitly should have also checked
that the dialog was connected to an active document. This CL
replaces several IsOpen() checks with IsOpenAndActive(), which
avoids a few crashes related to closedby.

Also see related spec issue:

https://github.com/whatwg/html/issues/11230

Fixed: 410878546,411623170
Change-Id: Ifc3d66b6a6632fe17acf0258f98bdb557724dc24

Reviewed-on: https://chromium-review.googlesource.com/6476484
WPT-Export-Revision: 8a6ce09553b1d075e1208fcc389787ef40936ce7

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=60d932ebcb01787d8c7abbe405e6154d1e6676fd

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 12 subtests

Status Summary

Firefox

OK : 1
PASS: 12

Chrome

OK : 1
PASS: 12

Safari

OK : 1
PASS: 12

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/4178b02215b4
[wpt PR 52105] - Add connectedness/activity check for IsOpen for dialogs, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4178b02215b4