1962056 - Some more BrowserGlue simplification/splitting

Status: RESOLVED FIXED

(Firefox :: General, task)

Description

[:Gijs (out until Jan 5th; he/him)]

Split from bug 1958070 for release tracking purposes.

Comment 1

[:Gijs (out until Jan 5th; he/him)]

Attachment: Bug 1962056 - move places initialization out of BrowserGlue, r?#places-reviewers

Places frontend initialization is surprisingly complex, and disentangling it
from the rest of startup by moving it to its own file helps make some of the
logic a little more obvious, and makes unit-testing a bit easier.

This also removes BrowserGlue from the indirection mechanism used between
MigatorBase instances and Places, by switching to category-manager-based
invocation - this way, migrator code does not need to directly
call places code to tell it it's done, but we don't need BrowserGlue to play
messenger between them.

It would be nice to do the same thing for places-init-complete but
that is notified from C++ code so unfortunately that is not easily possible.

Comment 2

[:Gijs (out until Jan 5th; he/him)]

Attachment: Bug 1962056 - use the category manager for first window ready initialization, r?#firefox-desktop-core-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50168e035edf
move places initialization out of BrowserGlue, r=places-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,mossop,mak,mconley

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/50168e035edf

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02a5e96cbeb8
use the category manager for first window ready initialization, r=firefox-desktop-core-reviewers ,mossop

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35eb9cf6b15a
Revert "Bug 1962056 - use the category manager for first window ready initialization, r=firefox-desktop-core-reviewers ,mossop" for causing xpc/bc related failures.

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing xpc/bc windows related failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/35eb9cf6b15a28d3c9954b12ad2eb54cd8a43d3b

Push with failures

Failure log bc

Failure log xpc

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f5855c3befc
use the category manager for first window ready initialization, r=firefox-desktop-core-reviewers ,mossop

Comment 9

[amarc]

Relanded this, it was not the culprit for the failures, sorry for that

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2f5855c3befc