1962112 - cZ change nick menu not working

Status: RESOLVED FIXED

(SeaMonkey :: Chat, defect)

Description

[Ian Neal]

Somehow managed to break nickname changing in the popup menu next to the input bar. Workaround is use /nick <nickname> from the input bar.

Comment 1

[Ian Neal]

Attachment: 1962112-irc-getdefaultcontext-event-25321.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1957763
User impact if declined: cannot change nickname through menu, have to use /nick command
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Pass event to getDefautContext where potentially needed.

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9480655 [details] [diff] [review]
1962112-irc-getdefaultcontext-event-25321.patch

lgtm r/a+

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4f5e886e19ce
cZ change nick menu not working. r=frg DONTBUILD

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/b796219caa6d4de4cd2b9d267224039593228f49
cZ change nick menu not working. r=frg a=frg