1962243 - Deduplicate code for centering dialogs in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, task)

Description

[Ian Neal]

At the moment we have similar code in 4 different places for position dialogs central to cZ. We can de-duplicate by adding a helper to utils.js

Comment 1

[Ian Neal]

Attachment: 1962243-irc-center-dialog-25322.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.22pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9480668 [details] [diff] [review]
1962243-irc-center-dialog-25322.patch

LGTM r/a+

Wonder if the resize on macOS couldn't be done better but something for later. MIght not be ok with HiDPI but not worse than today.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/abd150b4ebd8
Deduplicate code for centering dialogs in cZ. r=frg DONTBUILD

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/6ae67f429bb962aafc29b4be8dd1761fac39e7a9
Deduplicate code for centering dialogs in cZ. r=frg a=frg