1962274 - Add a print-preview test with printInColor disabled

Status: RESOLVED FIXED

(Core :: Printing: Output, task)

Description

[Daniel Holbert [:dholbert]]

Bug 1961975 clued us into the fact that our automation tests don't currently exercise our print-preview UI with the black-and-white printing setting (printInColor disabled). We had a debug-only crash that tripped in that configuration for a few weeks without our automation detecting it.

--> Filing this bug on adding a test that exercises this codepath.

Here's a Try run[1], based on a build without bug 1961975's fix, which demonstrates that my new test (which I'll post shortly) does indeed serve as a regression test for bug 1961975. The orange "c1" test runs are cases where this test would have caught the problem - they all show PROCESS-CRASH | application crashed [@ nsINode::GetBoolFlag] | layout/base/tests/chrome/test_printpreview.xhtml which is the same crash described in bug 1961975.

[1] https://treeherder.mozilla.org/jobs?repo=try&revision=0d59416b17557eb468fcbcb187ec5c66150bd104

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1962274: Add a print-preview test with printInColor disabled. r?#layout

Comment 2

[Daniel Holbert [:dholbert]]

Try runs, with the test version that's in phabricator, rooted on a commit...

• before Bug 1961975's fix: https://treeherder.mozilla.org/jobs?repo=try&revision=b16e7709d932716f37d96f0f97802323c30639fe
• after Bug 1961975's fix: https://treeherder.mozilla.org/jobs?repo=try&revision=30630f92e6c4fdbe8dffcf33a01358bc73bd5eca

The test does trigger a crash on linux debug c1 in the "before" try run (which is good and indicates that it's giving us the test coverage that we need).

I don't know offhand how we're managing to avoid crashing on windows debug test runs in that same "before" Try run, but I'm not going to worry about it too much, since this is kind of an afterthought anyway and we've now got some test coverage for this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e13d255b2d52
Add a print-preview test with printInColor disabled. r=jwatt

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e13d255b2d52