196236 - no help text for junk mail controls pane

Status: VERIFIED FIXED

(Documentation Graveyard :: Help Viewer, defect)

Description

[james davis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3) Gecko/20030306
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3) Gecko/20030306

The text in the "Using Junk Mail Controls" is simply "text to come".
Hope this will be filled out a bit more before 1.3 is gold.

Reproducible: Always

Steps to Reproduce:
1.Mail, Tools, Junk Mail Controls, Help
2.
3.

Comment 1

[earthsound]

Mozilla 1.3b, Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b)
Gecko/20030210, Windows XP Pro, Build 2600.xpsp1.020828-1920

Confirmed in 1.3b. Hardware/OS should be changed...

Comment 2

[james davis]

changed hw/os to all/all

Comment 3

[Daniel Wang]

-> doc:user

Comment 4

[Daniel Wang]

check out bug 197991 attachment 120929 [details])

Comment 5

[Daniel Wang]

Attachment: mail_help.html

edited from from ver 1.16 .

cvs diff is not working. I think it's probably the file wasn't saved in unix
text file format. so I post the entire html instead.

Comment 6

[Daniel Wang]

-> Keller

Comment 7

[R.J. Keller]

Attachment: Daniel's changes.

Daniel, is this all the changes you made? There was a lot of garbage in the
patch, so I might of deleted something by accident.

Comment 8

[R.J. Keller]

Comment on attachment 132228 [details] [diff] [review]
Daniel's changes.

> +how to protect yourself from Spammers.</p>

hmm. Do we want to use this wording?

> +Then, you let it autoclassify new mail for you, and you continue
> +to correct it as it makes mistakes.</p>

How about this:
Then, you let it autoclassify new mail for you. If Mozilla makes any mistakes,
you can correct them.

This sentence looks a little long to me.

> +      listing, watch it catch messages that contain the klez virus
Let's not list specific viruses. Just say "catch messages that might contain a
virus."

> +<p>Besides using Junk Mail Controls, you can also use
> +<a href="#sender_filter">filters</a> to prevent junk mail.</p>

Although this may be true, I don't think that filters are commonly used for
junk mail purposes. Should we really show them here? This is an opinionated
thing, so if you don't agree with me, that's fine.

> +   <li><b>Enable Junk Mail Controls</b>: Toggle this option to activate or

Can we try and use <strong> tags instead of <b>?

> +   <li><p><b>Move incoming messages determined to be junk mail to</b>:

What the? Why is there a <p> tag in a <li> tag? Very bad!

> +   <li><b>Automatically delete junk messages older than</b> XX <b>days from

Just a picky thing, but let's just have one X.

> +<div class="boilerplate">
> +The following information is provided by mozilla.org for

Shouldn't this be at the top of the document? We shouldn't have this in the
middle.

> +<q>spammers lie</q> and do not follow the instructions; your reply

change "follow the" to "follow your"

> +<p>Unfortunately, unless you keep your e-mail address to some private
> +friends, sooner or later spammer

Let's change this to "unless you keep your e-mail address only with private
friends,"

> +<p>There has been no known incident of mail virus for Mozilla, so as

Let's not have this in the help docs, because if one comes up, we will be
giving incorrect information.

> +    the View menu, choose <q>Message Body As,</q> and then choose

<picky>Move the comma outside the </q>.</picky>

> +    <q>Simple HTML</q> or <q>Plain Text.</q>

<picky>Move the period outside the <q></picky>

> +    Also, open the View menu, and uncheck <q>Display Attachments Inline.</q></p>

Same as above.

> +    option and check <q>Display Attachments Inline.</q></p>

Same as above.

> +    choose <q>Preferences.</q>  In

Same as above.

> +    <p><a href="http://wp.netscape.com/security/basics/privacy.html?cp=sspmid#cookies">More information on cookies</a></p>

Do we really want to be linking to a Netscape website? I don't know if this is
a good idea.

> +     sure this is indeed true, open the View menu, then choose <q>Preferences.</q>

The period outside the <p> thing.

> +<a href="http://www.cybernothing.org/faqs/net-abuse-faq.html">Net Abuse FAQ</a>.

This is a help menu, not a spam information center. I think that these links
are best on maybe a mozilla.org page and not in Mozilla Help.



Also, note that documentation does not need sr.

Comment 9

[Daniel Wang]

Attachment: patch - add content to mail_help.html

2nd try. cvs diff works now that Neil fixed the dos-format issue.

I used .important class which conent_style.css doesn't have. We need one.

Do we need to change
/mailnews/base/resources/content/junkMail.js
/extensions/help/resources/locale/en-US/help-toc.rdf
so that the Junk Mail Controls option dialog points to "Junk Mail Controls
Options" instead of "Using Junk Mail Controls"?

If you think the extra information after "Junk Mail Controls and Filter" should
be moved out, I could put it as a separate article in start/1.4/ and link to
it.

Comment 10

[R.J. Keller]

Comment on attachment 132266 [details] [diff] [review]
patch - add content to mail_help.html

> +      <li><p>Click on the thread pane icon. (If you do not see it, click

You should not have a <p> tag in a <li> tag.

> +    the white listing (many mail virus send bulk messages

virus should be viruses

> +    Watch it catch messages that contain  catch messages that
> +    might contain a virus (e.g. klez)

what? catch a catch message? this is very confusing. Are there 2 definitions of
catch messages?

> +  <li>
> +    Make sure to correct the Junk control when it incorrectly labels
> +    messages either as junk or not junk.</li>
> +  </li>

The <li> tag is being closed twice.

> +<h2><a id="opt_out_junk">

let's stick to either doing <h2 id="opt_out_junk"> or <a name="opt_out_junk">.

> +<div class="boilerplate">

well, I'll let the boilerplate issue go since I'm not 100% sure what the style
is on boilerplates.

> +<a href="http://www.cybernothing.org/faqs/net-abuse-faq.html">Net Abuse FAQ</a>.

This is a help menu, not a spam information center. I think that these links
are best on maybe a mozilla.org page and not in Mozilla Help.

I know that I"m being picky but we need to stop degrading the HTML and bloat in
help.

If you fix these problems (or give an explanation as why you did not fix them),
I'll r= the next patch.

Comment 11

[R.J. Keller]

--> Daniel

Comment 12

[R.J. Keller]

*** Bug 221252 has been marked as a duplicate of this bug. ***

Comment 13

[Daniel Wang]

Since some of the stuff is not appropriate for Help, I've converted it to an
online tutorial (see bug 214845). What we could do is check in some of the text
and leave the rest as "supplementary material". Brant, care to review?

Comment 14

[R.J. Keller]

Daniel: We really should have junk mail control text in help. I just don't want
to  have references to other sites and, as always, clean HTML and clear
documentation :).

Comment 15

[Daniel Wang]

http://www.mozilla.org/start/1.5/extra/using-junk-control.html

Comment 16

[R.J. Keller]

hmm. After looking at that, I think that we should wait until 1.7a when the mail
help docs get split up (which they need really bad), then it might be easier to
do this.

Comment 17

[Daniel Wang]

Attachment: mozilla/extensions/help/resources/locale/en-US/images/mail_junk_column.png

Comment 18

[Daniel Wang]

Attachment: patch rv1

this patch depends on the .png image fix

Comment 19

[Daniel Wang]

Attachment: patch rv1.1

last patch has markup problem.

Comment 20

[R.J. Keller]

Comment on attachment 138578 [details] [diff] [review]
patch rv1.1

this looks good! Do we have any TOC/index updates?

Comment 21

[R.J. Keller]

Fix checked in.

Also added the image to jar.mn, since the patch forgot.

Comment 22

[Daniel Wang]

rlk, I think you checked in mail_junk_column.png as text file.

Comment 23

[R.J. Keller]

ok, that should fix it. These images are driving me nuts! I think someone needs
to make image files binary by default like the MozDev CVS server is.