Hide Open At Startup menu items for DCC Chat/File tabs and fix toggling of menuitem in cZ
Categories
(SeaMonkey :: Chat, defect)
Tracking
(Not tracked)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
Attachments
(1 file, 1 obsolete file)
|
6.39 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
It makes no sense to offer the user the option to have DCC Chat / File tabs to re-open at start up, so let's hide them.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: unneeded/broken menu items
Testing completed (on m-c, etc.): 2.53.22pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Also fix toggling of open at startup on tab context menu, before this fix it only toggles the selected tab not the tab the context menu is opened on.
|
||
Comment 3•22 days ago
|
||
Comment on attachment 9485387 [details] [diff] [review]
1962431-irc-fix-openatstartup-v1_1-25322.patch
LGTM r/a+
NIT 2 new lines go over 80 ch. Can be fixed or not.
(In reply to Frank-Rainer Grahl (:frg) from comment #3)
Comment on attachment 9485387 [details] [diff] [review]
1962431-irc-fix-openatstartup-v1_1-25322.patchLGTM r/a+
NIT 2 new lines go over 80 ch. Can be fixed or not.
The one in JS is probably easily fixable, not to sure about the one in XUL
|
|
||
Comment 5•21 days ago
|
||
Not worth it. Just one char over in the js and the xul files are all over the place wrt line length. Just a NIT :)
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/821ead04af32
Hide Open At Startup menu items for DCC Chat/File tabs and fix toggling of menuitem in cZ. r=frg DONTBUILD
Description
•