1962436 - DCC File transfer speed is calculated at infinity on fast links in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, defect)

Description

[Ian Neal]

If the connection speed is very fast then 100K can be transferred via DCC in less than 1ms so the current calculation for speed gives infinity as the answer. We should only try calculating after a certain amount of elapsed time (I picked 10ms) to avoid the impossible.

Comment 1

[Ian Neal]

Attachment: 1962436-irc-fix-dcctransfer-speed-25322.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: speed calculation is wrong
Testing completed (on m-c, etc.): 2.53.22pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9480935 [details] [diff] [review]
1962436-irc-fix-dcctransfer-speed-25322.patch

LGTM r/a+

NIT: For clarity I would pefer adding braces around the calculation:

if ((now - this._lastSpeedTime) > 10)

lmk if I should check it in with this change?

Comment 3

[Ian Neal]

(In reply to Frank-Rainer Grahl (:frg) from comment #2)

Comment on attachment 9480935 [details] [diff] [review]
1962436-irc-fix-dcctransfer-speed-25322.patch

LGTM r/a+

NIT: For clarity I would pefer adding braces around the calculation:

if ((now - this._lastSpeedTime) > 10)

lmk if I should check it in with this change?

Yeah, if it makes you happy :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6cf7f8524288
DCC File transfer speed is calculated at infiinity on fast links in cZ. r=frg DONTBUILD

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/32e11056755c52ca0c989e25f571566bd82123eb
DCC File transfer speed is calculated at infiinity on fast links in cZ. r=frg a=frg