Closed Bug 1962614 Opened 1 year ago Closed 1 year ago

Show biometric auth CFR to users when opening the tabs tray for the first time

Categories

(Firefox for Android :: Privacy, task)

All
Android
task

Tracking

()

RESOLVED FIXED
140 Branch
Tracking Status
firefox139 --- wontfix
firefox140 --- fixed

People

(Reporter: Gela, Assigned: Gela)

References

Details

(Whiteboard: [fxdroid][group2])

Attachments

(3 files, 1 obsolete file)

Product has confirmed we only want to show this CFR once when they first open the tabs tray.

Figma: https://www.figma.com/design/qiiSyigCsqDx9kNyxcGEev/BioAuth?node-id=307-9414&m=dev

Whiteboard: [fxdroid][group2]
Blocks: 1962616
Duplicate of this bug: 1962187
Pushed by gmalekpour@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/523f992b14e8 Add strings for PBM locked CFR r=android-reviewers,matt-tighe

Backed out changeset 523f992b14e8 (Bug 1962614) for causing fenix lint failures.

Push with failures

Failure log

Backout link

Flags: needinfo?(gmalekpour)
Backout by csabou@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/d5d75dde90f3 Backed out changeset 523f992b14e8 for causing fenix lint failures. CLOSED TREE
Pushed by gmalekpour@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cf17c23e4130 Add strings for PBM locked CFR r=android-reviewers,android-l10n-reviewers,matt-tighe,delphine
Attachment #9481091 - Attachment description: WIP: Bug 1962614 - Show biometric auth CFR to users when opening the tabs tray for the first time → WIP: Bug 1962614 - Show biometric auth CFR to users when opening the tabs tray for the first time Differential Revision: https://phabricator.services.mozilla.com/D244283
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Flags: needinfo?(gmalekpour)
Resolution: FIXED → ---
Attachment #9481091 - Attachment description: WIP: Bug 1962614 - Show biometric auth CFR to users when opening the tabs tray for the first time Differential Revision: https://phabricator.services.mozilla.com/D244283 → WIP: Bug 1962614 - Show biometric auth CFR to users when opening the tabs tray for the first time
Attachment #9484316 - Flags: approval-mozilla-beta?

beta Uplift Approval Request

  • User impact if declined: Missing strings required for biometric auth prompt
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: N/A. Strings only
  • Risk associated with taking this patch: N/A
  • Explanation of risk level: Low, just adding strings.
  • String changes made/needed: Yes
  • Is Android affected?: yes

Hi Bryan, any concerns with uplifting these new strings to Beta?

Flags: needinfo?(bolsson)
Attachment #9484417 - Attachment description: WIP: Bug 1962614 - Add banner to encourage users to enable biometric authentication → Bug 1962614 - Add banner to encourage users to enable biometric authentication
Attachment #9481091 - Attachment is obsolete: true

(this is not desktop, redirecting)

Flags: needinfo?(bolsson) → needinfo?(lebedel.delphine)
Pushed by gmalekpour@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c38333bb0f2c Add banner to encourage users to enable biometric authentication r=android-reviewers,twhite,android-l10n-reviewers,delphine

String freeze is past so there is chance some locales may not get to localize these strings in time - which may lead to poor UI experince. Since there are not that many strings and if they are crucial to this release, then let's uplift them

Flags: needinfo?(lebedel.delphine)
Attachment #9484316 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: REOPENED → RESOLVED
Closed: 1 year ago → 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 140 Branch
Regressions: 1964209
Regressions: 1964409
Regressions: 1964240
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: