Closed Bug 1962699 Opened 2 months ago Closed 2 months ago

Use our custom `IconButton` composable in `TrailingIconScope`

Categories

(Firefox for Android :: Design System and Theming, task)

Product:
Firefox for Android
Component:
Design System and Theming
Platform:
All
Android
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
140 Branch
Tracking Flags:
Tracking Status
firefox140 --- fixed

People

(Reporter: npoon, Assigned: victor.mours, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [fxdroid] [group4])

Attachments

(1 file)

Bug 1962699 - Use our custom `IconButton` composable in `TrailingIconScope` r=npoon
48 bytes, text/x-phabricator-request
Details | Review

Currently, TrailingIconScope uses Material's Iconbutton. See here. Let's use our own IconButton instead (searchfox).

Then, let's change the Icon's content description to null and set the content description in the IconButton. If the content description is null, we can pass in empty string

Assignee: nobody → victor.mours
Status: NEW → ASSIGNED
Pushed by npoon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8f8ec061d3cf Use our custom `IconButton` composable in `TrailingIconScope` r=npoon,android-reviewers

https://hg.mozilla.org/mozilla-central/rev/8f8ec061d3cf

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox140: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 140 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: