1963017 - Biometric authenticator displayed again after success authentication

Status: RESOLVED FIXED

(Firefox for Android :: Privacy, defect, P1)

Description

[Rebeca Tudor]

Attachment: Screen_recording_20250428_140520.mp4

Steps to reproduce

1. Enable Settings -> Private browsing -> Use screen lock to hide tabs in private browsing
2. open at least 1 tab in private mode
3. go to normal mode
4. open tabs tray
5. tap on private button
6. authenticate
7. tab again on the private button

Expected behavior

The authentication prompt will not be displayed again.

Actual behavior

The authentication prompt is displayed again.

Comment 1

[Mike a [:mavduevskiy]]

Attachment: Bug 1963017 - Don't request authentication on private tab click if already authed

Comment 2

[Rebeca Tudor]

Attachment: Bug 1963017 - Verify if private tabs page is already active

To not displayed again after success authentication when
tapping on the private tabs button from tabs tray we verify
if we are already in the private tabs page.

Comment 3

[Mike a [:mavduevskiy]]

Attachment: Bug 1963017 - Part 1: Fix authentication prompt for access private tabs in tabs tray

Comment 4

[Mike a [:mavduevskiy]]

Attachment: WIP: Bug 1963017 - Part 2: Fix authentication prompt in the browser fragment

This patch was aimed to solve these bugs: 1) restarting the app with private tabs from the normal mode and then opening a private tab 2) letting the system to kill the activity with opened private tab and then locking it 3) pressing remove private tabs notification from normal page and opening a private tab 4) pressing remove private tabs notification from private page and opening a new page

Comment 5

[Mike a [:mavduevskiy]]

Other bugged behaviour: visible private tabs after recreate (video) and cached lock flag after app manual kill and restart (video)

Comment 6

[Rebeca Tudor]

Attachment: Bug 1963017 - Verify if private tabs page is already active

To not displayed again after success authentication when
tapping on the private tabs button from tabs tray we check
if we are already in the private tabs page.

Comment 7

[Phabricator Automation]

Comment on attachment 9484928 [details]
WIP: Bug 1963017 - Part 2: Fix authentication prompt in the browser fragment

Revision D247527 was moved to bug 1964181. Setting attachment 9484928 [details] to obsolete.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17f5645c94f3
Verify if private tabs page is already active r=android-reviewers,twhite

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/17f5645c94f3