1963046 - Allow to create a new geckoview tab in a specific user context

Status: NEW

(GeckoView :: General, task, P1)

Description

[Julian Descottes [:jdescottes]]

To support WebDriverBiDi's browsingContext.create command, we need an API to open a tab/window in an existing user context for Firefox for Android.

This is blocking Bug 1877953 on BiDi side (there is already some conversation about which APIs BiDi is using at the moment there).

Makoto, you seemed to have some ideas on how we could fix this in https://bugzilla.mozilla.org/show_bug.cgi?id=1877953#c4, can you share more details on how to fix this?

Comment 1

[Makoto Kato [:m_kato]]

Does it depends on usercontextid in browser element?

When opening new window (nsIWindowWatcher.openWindow might be called) by script, I guess that GeckoView doesn't set "usercontextid" in browser element. Also, WebDriver might use internal mthod (in GeckoViewTabUtils) to open new window, but I guess that we don't set it too.

Comment 2

[Makoto Kato [:m_kato]]

And GeckoViewTabUtil.userContextId will return same value from GeckoView Java API.

Comment 3

[Cathy Lu [:calu]]

Would resolving bug1641420 help alleviate this?

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Cathy Lu [:calu] from comment #3)

Would resolving bug1641420 help alleviate this?

No.

When I investigate WebDriver's userContextId handling, it have to be stored in browsing context. I will add concept WIP for this issue. (I only test for testing/web-platform/tests/webdriver/tests/bidi/browsing_context/create, it seems to works.)

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Bug 1963046 - Part 1. Attach usercontextid when creating window. r=#geckoview-reviewers!,#webdriver-reviewers!

Comment 6

[Makoto Kato [:m_kato]]

Attachment: Bug 1963046 - Part 2. Don't use hasAttribute and getAttritue to access usercontextid in tab. r=#geckoview-reviewers!,#webdriver-reviewers!

GeckoView's tab isn't XUL element. so we have to emulate some methods.

Comment 7

[Makoto Kato [:m_kato]]

Attachment: Bug 1963046 - Part 3. run sucessful tests. r=#webdriver-reviewers!

Although webdriver/tests/bidi/browser/remove_user_context/user_context.py.ini
isn't still passed, we should run more tests that is successful.