Closed
Bug 1963095
Opened 2 months ago
Closed 2 months ago
DesktopModeRepositoryTest unnecessarily uses mock static to set value for an internal property
Categories
(Firefox for Android :: General, task)
Tracking
()
RESOLVED
FIXED
140 Branch
| Tracking | Status | |
|---|---|---|
| firefox140 | --- | fixed |
People
(Reporter: mcarare, Assigned: mcarare)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][group6])
Attachments
(1 file)
The only reason for using static mocking of Context::isLargeScreenSize method is that the test can set the value of defaultDesktopMode, value that can also be set by using normal mocking.
|
Assignee | |
Updated•2 months ago
|
Whiteboard: [fxdroid][group6]
|
||
Updated•2 months ago
|
|
|
Assignee | |
Comment 1•2 months ago
|
||
Pushed by mcarare@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/265ad8b1e897
Use spy to mock defaultDesktopMode in DesktopModeRepositoryTest. r=android-reviewers,jonalmeida
|
||
Comment 3•2 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox140:
--- → fixed
Resolution: --- → FIXED
|
||
Updated•2 months ago
|
Target Milestone: --- → 140 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•