Closed Bug 1963178 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 52216 - Implement base appearance for in-page select elements

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
140 Branch
Tracking Status
firefox140 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(2 files)

Sync web-platform-tests PR 52216 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52216
Details from upstream follow.

Joey Arhar <jarhar@chromium.org> wrote:

Implement base appearance for in-page select elements

This patch makes appearance:base-select work for \<select size> and
\<select multiple> when they are rendered as an in-page "ListBox".

The keyboard behavior for base appearance in-page selects is
significantly different than the appearance:auto version in order to
make it easy to choose multiple options in a \<select multiple>:
https://github.com/openui/open-ui/issues/113

\<select multiple> with a popup, which is currently only supported on
mobile, does not support base appearance yet with this patch.

Bug: 357649033
Change-Id: Ida1258849c370efe1632bebf7d26661a0c76835c

Reviewed-on: https://chromium-review.googlesource.com/5893011
WPT-Export-Revision: 8f36c914eade4a6d31291730e269fdb54bfc9821

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 4 subtests

Status Summary

Firefox

OK : 2
FAIL: 8

Chrome

OK : 2
PASS: 1
FAIL: 7

Safari

OK : 2
FAIL: 8

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Component: CSS Parsing and Computation → DOM: Core & HTML

Automatic update from web-platform-tests
Implement base appearance for in-page select elements

This patch makes appearance:base-select work for <select size> and
<select multiple> when they are rendered as an in-page "ListBox".

The keyboard behavior for base appearance in-page selects is
significantly different than the appearance:auto version in order to
make it easy to choose multiple options in a <select multiple>:
https://github.com/openui/open-ui/issues/113

<select multiple> with a popup, which is currently only supported on
mobile, does not support base appearance yet with this patch.

Bug: 357649033
Change-Id: Ida1258849c370efe1632bebf7d26661a0c76835c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5893011
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1452912}

--

wpt-commits: c6a8e616cd26012292c134ae61c9fe251d4f1799
wpt-pr: 52216

Pushed by aborovova@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8264cee93f80 [wpt PR 52216] - Implement base appearance for in-page select elements, https://hg.mozilla.org/integration/autoland/rev/55839b7f3eab [wpt PR 52216] - Update wpt metadata,
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 140 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: