1963194 - webgl tests failing on samsung a55

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in trying to migrate our android hardware unittests from pixel5 to a55 phones some webgl tests are failing.

A few things:

• debug has a crash, it seems to be on dozens of tests
• opt has an issue with test_renderer_strings, specifically: [ignore if not on CI] getParameter(renderer) -> 'Generic Renderer' must be in KNOWN_ON_CI. I have added Generic Renderer to the test case an still get a failure.

I will attach a WIP for this so the extent of the failure are more well documented.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: WIP: - Bug 1963194 - webgl test failures on samsung a55.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

:jgilbert, is there anything in the attached patch or info that could help reduce the need for so many skip-ifs?

Comment 3

[Jamie Nicol [:jnicol]]

Bug 1940933 might fix the renderer strings issue?

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

:jnicol- yes Bug 1940933 seems to fix the renderer strings, here is the output:

[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -  TEST-START | dom/canvas/test/webgl-mochitest/test_renderer_strings.html
[task 2025-05-02T19:49:41.816Z] 19:49:41  WARNING -  TEST-UNEXPECTED-FAIL | dom/canvas/test/webgl-mochitest/test_renderer_strings.html | [ignore if not on CI] getParameter(renderer) -> 'ANGLE (Samsung Xclipse 920) on Vulkan, or similar' must be in KNOWN_ON_CI
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:426:16
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -      testKnownCiStrings@dom/canvas/test/webgl-mochitest/test_renderer_strings.html:94:7
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -      async*@dom/canvas/test/webgl-mochitest/test_renderer_strings.html:226:9
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -      @dom/canvas/test/webgl-mochitest/test_renderer_strings.html:231:3
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -  TEST-PASS | dom/canvas/test/webgl-mochitest/test_renderer_strings.html | [ignore if not on CI] getParameter(vendor) -> 'Mozilla' must be in KNOWN_ON_CI
[task 2025-05-02T19:49:41.816Z] 19:49:41  WARNING -  TEST-UNEXPECTED-FAIL | dom/canvas/test/webgl-mochitest/test_renderer_strings.html | [ignore if not on CI] getParameter(unmasked_renderer) -> 'ANGLE (Samsung Xclipse 530) on Vulkan 1.3.231' must be in KNOWN_ON_CI
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:426:16
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -      testKnownCiStrings@dom/canvas/test/webgl-mochitest/test_renderer_strings.html:94:7
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -      async*@dom/canvas/test/webgl-mochitest/test_renderer_strings.html:226:9
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -      @dom/canvas/test/webgl-mochitest/test_renderer_strings.html:231:3
[task 2025-05-02T19:49:41.816Z] 19:49:41  WARNING -  TEST-UNEXPECTED-FAIL | dom/canvas/test/webgl-mochitest/test_renderer_strings.html | [ignore if not on CI] getParameter(unmasked_vendor) -> 'Samsung Electronics Co., Ltd.' must be in KNOWN_ON_CI
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:426:16
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -      testKnownCiStrings@dom/canvas/test/webgl-mochitest/test_renderer_strings.html:94:7
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -      async*@dom/canvas/test/webgl-mochitest/test_renderer_strings.html:226:9
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -      @dom/canvas/test/webgl-mochitest/test_renderer_strings.html:231:3
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -  TEST-PASS | dom/canvas/test/webgl-mochitest/test_renderer_strings.html | When pref disabled: Should not have access to 'WEBGL_debug_renderer_info'.
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -  TEST-PASS | dom/canvas/test/webgl-mochitest/test_renderer_strings.html | v92 behavior w/o ext: Was {"renderer":"ANGLE (NVIDIA, NVIDIA GeForce GTX 980 Direct3D11 vs_5_0 ps_5_0), or similar","vendor":"Mozilla"}
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -  TEST-PASS | dom/canvas/test/webgl-mochitest/test_renderer_strings.html | With RFP: Should not have access to 'WEBGL_debug_renderer_info'.
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -  TEST-PASS | dom/canvas/test/webgl-mochitest/test_renderer_strings.html | RFP behavior: Was {"renderer":"Mozilla","vendor":"Mozilla"}
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -  TEST-PASS | dom/canvas/test/webgl-mochitest/test_renderer_strings.html | By default: Should have access to 'WEBGL_debug_renderer_info'.
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -  TEST-PASS | dom/canvas/test/webgl-mochitest/test_renderer_strings.html | v92 behavior: Was {"renderer":"ANGLE (NVIDIA, NVIDIA GeForce GTX 980 Direct3D11 vs_5_0 ps_5_0), or similar","vendor":"Mozilla","unmasked_renderer":"ANGLE (NVIDIA, NVIDIA GeForce GTX 980 Direct3D11 vs_5_0 ps_5_0), or similar","unmasked_vendor":"Google Inc."}
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -  TEST-PASS | dom/canvas/test/webgl-mochitest/test_renderer_strings.html | v91 behavior: Was {"renderer":"Mozilla","vendor":"Mozilla","unmasked_renderer":"ANGLE (NVIDIA, NVIDIA GeForce GTX 980 Direct3D11 vs_5_0 ps_5_0), or similar","unmasked_vendor":"Google Inc."}
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -  TEST-PASS | dom/canvas/test/webgl-mochitest/test_renderer_strings.html | v90 behavior: Was {"renderer":"Mozilla","vendor":"Mozilla","unmasked_renderer":"ANGLE (NVIDIA, NVIDIA GeForce RTX 3070 Direct3D11 vs_5_0 ps_5_0, D3D11-27.21.14.5751)","unmasked_vendor":"Google Inc."}
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -  TEST-PASS | dom/canvas/test/webgl-mochitest/test_renderer_strings.html | Test complete.
[task 2025-05-02T19:49:41.816Z] 19:49:41     INFO -  TEST-OK | dom/canvas/test/webgl-mochitest/test_renderer_strings.html | took 302ms

this means that we have actual values to work with.

so we have two questions:

1. when can 1940933 land? :)
2. how to fix the crashes we see on debug.

Comment 5

[Jamie Nicol [:jnicol]]

The logcat seems to show the debug crash is an assertion when failing to parse the renderer string, so I think it should also be fixed by the same bug.

Nothing blocking landing it I think it just fell off our radar. Kelsey, are you able to re-review it? I believe I made the changes you previously requested.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

great, I can make some adjustments once bug 1940933 lands. Thanks for the help so far

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1963194 - green up and migrate mochitest-webgl from android pixel5 -> a55.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ba3898fa3330
https://hg.mozilla.org/integration/autoland/rev/0b7b6e891282
green up and migrate mochitest-webgl from android pixel5 -> a55. r=jnicol,aryx

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0b7b6e891282