1963270 - app.kosmi.io - Missing "Local file" option from the "Select media" pop-up

Status: ASSIGNED

(Web Compatibility :: Interventions, defect, P2)

Description

[Raul Bucata]

Environment:
Operating system: Windows 10
Firefox version: Firefox 139.0

Steps to reproduce:

1. Navigate to: https://app.kosmi.io/
2. Perform account login via Google
3. Create a room
4. From the room options, select the "Select media" option
5. Observe the upper left side of the "Select media" pop-up

Expected Behavior:
3 options are present, including the "Local file" option

Actual Behavior:
2 options are present, the "Local file" option is missing

Notes:

• Reproduces regardless of the status of ETP
• Reproduces in firefox-nightly, and firefox-release
• Does not reproduce in chrome

Created from https://github.com/webcompat/web-bugs/issues/154252

Comment 1

[Raul Bucata]

Attachment: chrome showing the correct behaviour

Comment 2

[Daniel Holbert [:dholbert]]

Not sure, but as a guess: this might depend on the file system access DOM API (bug 1905871) where we have a negative standards-position on, per https://github.com/mozilla/standards-positions/issues/154

--> Reclassifying to diagnosis-team:dom on the basis of that guess to help clear the webcompat team's triage queue, since I think that's the team closest to that API and related features.

Comment 3

[Sean Feng [:sefeng211]]

The site has code like this

          b = (0, x.useRef) (document.createElement('video'));
          return {
            isMobile: y,
            isIOS: u,
            isAndroid: S,
            isMobileOS: u ||
            S,
            isLandscape: p,
            isBeingEmbedded: I,
            hasScreenshareWithAudio: g,
            canCaptureVideoElement: !!b.current.captureStream,
            supportsRestrictionTarget: !!((d = window.RestrictionTarget) != null && d.fromElement)
          }

It's caused by the canCaptureVideoElement: !!b.current.captureStream. Firefox only supports mozCaptureStream, overriding the script to change it to mozCaptureStream fixes it.

Comment 4

[Sean Feng [:sefeng211]]

This goes to media team's queue.

Comment 5

[Daniel Holbert [:dholbert]]

Thanks, Sean!

Given comment 3, it looks like we can consider this diagnosed as a form of bug 1541471 (on shipping the captureStream feature). Let's just mark it as-such.

Comment 6

[Daniel Holbert [:dholbert]]

I think there's a chance we could sitepatch this with some hacky JS that does foo.captureStream = foo.mozCaptureStream for some foo (I'm hand-waving a bit, but you get the idea.)

Not sure if our prefixed implementation works or not with this particular site; comment 3 suggests that maybe it does, so it'd probably worth attempting an intervention if someone has the time (given that the underlying bug 1541471 is currently webcompat:blocked-resources).

Comment 7

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1963270 - add a JS webcompat intervention for app.kosmi.io so their select-local-media-file option is available; r?denschub

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/674d600b690d
add a JS webcompat intervention for app.kosmi.io so their select-local-media-file option is available; r=denschub,webcompat-reviewers

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/674d600b690d

Comment 10

[Thomas Wisniewski [:twisniewski]]

We've shipped captureStream for a while now (bug 1541471), so I'll adjust the intervention to only apply when media.captureStream.enabled is false and on older Firefox versions.

Comment 11

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1963270 - only apply our webcompat intervention for app.kosmi.io when needed; r?ksenia

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e693efc4f59f
https://hg.mozilla.org/integration/autoland/rev/d350fbdde49b
only apply our webcompat intervention for app.kosmi.io when needed; r=webcompat-reviewers,denschub

Comment 13

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests failures in browser_ua_helpers.js.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/extensions/webcompat/tests/browser/browser_ua_helpers.js | test_ua_helpers - getDeviceAppropriateChromeUA({"ua":"Linux","config":{"OS":"windows","noFxQuantum":true},"expected":"Mozilla/5.0 (Windows NT 11.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/143.0.0.0 Safari/537.36"}) - Got "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/143.0.0.0 Safari/537.36",

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4ad0b4954e31
https://hg.mozilla.org/integration/autoland/rev/1e809ccca198
only apply our webcompat intervention for app.kosmi.io when needed; r=webcompat-reviewers,denschub

Comment 15

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/1e809ccca198