1963354 - Fix the GTK version checked for decalring some constants in widget/gtk/nsWindow.cpp

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Pier Angelo Vendrame]

Bug 1919115 introduced this block:

#if !GTK_CHECK_VERSION(3, 22, 0)

constexpr gint GDK_WINDOW_STATE_TOP_TILED = 1 << 9;
constexpr gint GDK_WINDOW_STATE_TOP_RESIZABLE = 1 << 10;
constexpr gint GDK_WINDOW_STATE_RIGHT_TILED = 1 << 11;
constexpr gint GDK_WINDOW_STATE_RIGHT_RESIZABLE = 1 << 12;
constexpr gint GDK_WINDOW_STATE_BOTTOM_TILED = 1 << 13;
constexpr gint GDK_WINDOW_STATE_BOTTOM_RESIZABLE = 1 << 14;
constexpr gint GDK_WINDOW_STATE_LEFT_TILED = 1 << 15;
constexpr gint GDK_WINDOW_STATE_LEFT_RESIZABLE = 1 << 16;

#endif

However, these constants were introduced in GTK 3.22.23 (see https://gitlab.gnome.org/GNOME/gtk/-/blob/gtk-3-22/gdk/gdkevents.h).

Therefore, Firefox fails to Build on Debian 9, which provides GTK 3.22.11.

Comment 1

[Pier Angelo Vendrame]

Attachment: Bug 1963354 - Refine the GTK version checked before declaring various GDK_WINDOW_STATE... constants. r?emilio

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1919115

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6ce04dd2eaa
Refine the GTK version checked before declaring various GDK_WINDOW_STATE... constants. r=emilio

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f6ce04dd2eaa

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:pierov, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox139 to wontfix.

For more information, please visit BugBot documentation.