1963439 - newtab Inferred personalization setup places db tables, indices and migrations for impressions and clicks

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1963439 - newtab Inferred personalization setup places db tables, indices and migrations for impressions and clicks.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c511ceb62edc
newtab Inferred personalization setup places db tables, indices and migrations for impressions and clicks. r=mak

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c511ceb62edc

Comment 4

[Marco Bonardo [:mak]]

I just noticed a possible typo in CREATE_IDX_MOZ_NEWTAB_IMPRESSION_TIMESTAMP that seems to refer to the clicks table instead.

I also see errors in the browser console like "Error: Error(s) encountered during statement execution: no such table: moz_newtab_story_click_idx_newtab_impression_timestamp" due to this code that was assuming indices name ended by "index". I honestly didn't remember about that. I think the code is a bit fragile, it should probably check the entity type SELECTing by name from "sqlite_master".

The former will require another db migration to be fixed (we can avoid having a new test though), removing the old index and creating the correct one.

Comment 5

[Scott [:thecount] Downe]

Yup I think you're right.

I'm not really sure how to write a migration for this yet.

Any help or examples of a similar previous migration is appreciated.

We should probably make another bug for this right?

Comment 6

[Marco Bonardo [:mak]]

yeah, we need a separate bug. The migration is pretty much similar, bump up version, DROP INDEX IF EXISTS name, call new CREATE_IDX_ macro