1963597 - Nursery tenured allocation rate is no longer shown in the profiler

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Jon Coppeard (:jonco)]

This used to be present in GCMinor markers in the profiler but was broken when we added strings to the nursery back in bug 1692359. This changed the names of the minor GC phases which the profiler used to calculate the rate.

Instead, we should calculate this in the JS engine and simplify the profiler code.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1963597 - Send tenured allocation rate to profiler r?sfink

Currently the profiler calculats from phase times, but it is broken because the
names of the phases have changed. We will move to calculating this in the
engine instead.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/281909f9148b
Send tenured allocation rate to profiler r=sfink

Comment 3

[Jon Coppeard (:jonco)]

The corresponding profiler change is in: https://github.com/firefox-devtools/profiler/pull/5440

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/281909f9148b