1963827 - When malformed PDF is generated, investigate whether we can verify the pdf before sending it to android

Status: ASSIGNED

(GeckoView :: General, task)

Description

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

As seen in Bug 1961443, if a malformed PDF is generated in the print preview, fenix just crashes with java.lang.RuntimeException: Cannot print a malformed PDF file. On the GV side, we should consider preventing the app from crashing by catching this exception.

We do a lot of the PDF processing in GeckoViewPrintDocumentAdapter.java. makeTempPdfFile seems like a place we could check if it is actually a PDF or somewhere in that area.

It may also be checking something around here

Comment 1

[Faisal Masalha]

Attachment: Bug 1963827 When malformed PDF is generated, investigate whether we can verify the pdf before sending it to android r=ohall

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/eb34c7ab4cb7
https://hg.mozilla.org/integration/autoland/rev/7b46d6933f5b
When malformed PDF is generated, investigate whether we can verify the pdf before sending it to android r=ohall,geckoview-reviewers,geckoview-api-reviewers,android-reviewers,calu

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8fd53df390bf
https://hg.mozilla.org/integration/autoland/rev/6834140454c9
Revert "Bug 1963827 When malformed PDF is generated, investigate whether we can verify the pdf before sending it to android r=ohall,geckoview-reviewers,geckoview-api-reviewers,android-reviewers,calu" for causing print related Android crashes.

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for causing print related Android crashes.

Push with failures

Failure log

Backout link

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:fmasalha, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 6

[Olivia Hall [:olivia]]

We're still looking at the test failure and looking for the fix. The failure is due to something subtle happening in CI that doesn't reproduce locally, so harder to debug. Root cause is probably due to a test cleanup or a test timing issue on the newly introduced malformed PDF test and the print spooler.