1963954 - Remove the direct dependency of appservices search from the fenix/app/build.gradle

Status: RESOLVED FIXED

(Firefox for Android :: Search, defect)

Description

[Jonathan Almeida [:jonalmeida]]

With bug 1944964, our feature-search component and fenix now depending on our app services component. We should avoid leaking our dependencies through the abstractions and making the our module component and the app have the same dependency because this leads us closer to having circular dependencies or lead to application code interacting with the dependency directly and cause a broken state.

In this particular case, the dependency is mostly needed for enums or , so a possible solution could be to map one enum to an AC enum - which is probably a bit heavy, but we do have fairly good examples of this:

• Sync types.
• Push types.
• Engine tracker types.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1944964

:harrisono, since you are the author of the regressor, bug 1944964, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[[:harrisono]]

Attachment: Bug 1963954 - Remove dependency for application-services search from Fenix.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8a89a82fd36
Remove dependency for application-services search from Fenix. r=android-reviewers,jonalmeida

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f8a89a82fd36

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:harrisono, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox139 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[[:harrisono]]

Change is not important enough to warrant an uplift to beta for 139.
marking 139 as "wontfix"