196404 - setting document.location.href while showing about:blank broken

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Setting document.location.href from a bookmarklet is now broken if the current
page being shown is about:blank.  This is a regression caused by radha's checkin
to nsLocation.cpp, revision 1.107, for bug 162128.

Steps to reproduce:
 1. bookmark the URL (perhaps in the personal toolbar):
javascript:void(id=prompt('Show Mozilla bug
no.',''));if(id){void(location.href='http://bugzilla.mozilla.org/show_bug.cgi?id='+escape(id)+'
')}
 2. load about:blank in a Window (I'm using Phoenix, but I'd guess it doesn't
matter whether one uses Phoenix or Mozilla)
 3. Click the bookmark.
 4. Type a bug number into the alert.

Expected results:
 * load that bug number

Actual results:
 * error on JS console saying that nsIDOMLocation.href setter returned
NS_ERROR_FAILURE.

Comment 1

[Harshal Pradhan]

Attachment: fix

Restores old behavior if the attempt to figure out a "more useful" base URI
doesnt work. (In this particular case, we have a root docshell with a
about:blank uri. FindUsableBaseURI() really cant do anything smart.)

Comment 2

[Christopher Blizzard (:blizzard)]

Blocking 1.4a since it's a regression and we hate those.

Comment 3

[Harshal Pradhan]

Taking bug since I already have a patch.

Comment 4

[Harshal Pradhan]

Checked in.