1964046 - After bug 1964022, titlebar buttons with adwaita look a bit off.

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

Since they still use the old GTK3 buttons.

I think the ideal thing to do would be to render the buttons on our own, but using the right icon theme and foreground color. That would even allow us to get rid of the "non-native" titlebar buttons too.

What we want is really using the window-{maximize,minimize,restore,close}-symbolic icons. moz-icon:// exposes them but only with 1x resolution. I hacked nsIconChannel to allow sending icons with 2x scale (so that they look crisp on HiDPI), but even with that there's another issue, which is that those icons should change with the color scheme of the window (kinda like context-properties).

So for the scale I can hack around it, either by hardcoding a bigger scale, or passing it in the query string and using image-set() in the front-end. But I'm guessing the foreground color bit is not that easy to hack around (at least I haven't found an easy way).

I'm assuming that if I were to make that work, I'd need some new vector-like image type (so that we can decode-per-color or so)? Or can you think of another way of making something like that work?

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1964046 - Add support for scale and color-scheme to moz-icon:// URIs on GTK. r=stransky!

This doesn't quite work because on color scheme changes they stay
frozen.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

^ is what I was trying fwiw.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1964046 - Use HiDPI icons in preferences app list. r=#preferences-reviewers

Using this for the action icon and such is harder.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1964046 - Use HiDPI symbolic icons for the titlebar. r=stransky!

This looks better on the native theme, and on the built-in themes too.

It's a mixed improvement and regression for non-native themes:

• On one hand, we use the system icons.
• On the other, we don't use the theme fill (which usually would be
  used via context-fill / context-stroke).

So over-all I think it's worth it.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1964046 - Remove unused native titlebar drawing code. r=stransky

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1964046 - Avoid falling back to cairo for window decorations on wayland. r=stransky

As we don't really need them. This avoids non-webrender drawing on the
main window altogether.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

https://treeherder.mozilla.org/jobs?repo=try&revision=397880f787849aefdde1a42cfc36e2cf36c58c16

Comment 8

[Jens Persson]

Nice to see the icon decoder gets updated, very much needed. I see that detecting text direction from file endings (ltr/rtl) is gone. Maybe it's just old school scheme and not needed anymore? And this is more of a feature request, would it not be possible to get rid of gtkiconsize as it's completely different in gtk4? If it's hardcoded upstreams in gtk3 you might as well hardcode it yourself? And get rid of gtk_icon_size_lookup in the process. But this is a huge rework that gets rid of basically everything that is already deprecated in gtk3, good work!!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eee332f4853b
Add support for scale and color-scheme to moz-icon:// URIs on GTK. r=stransky

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c3a64943da8
Remove unused native titlebar drawing code. r=stransky

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/025d3cf31593
Avoid falling back to cairo for window decorations on wayland. r=stransky

Comment 12

[Emilio Cobos Álvarez [:emilio]]

(In reply to Jens Persson from comment #8)

Nice to see the icon decoder gets updated, very much needed. I see that detecting text direction from file endings (ltr/rtl) is gone. Maybe it's just old school scheme and not needed anymore?

Yeah we don't use any icon names ending in ltr/rtl afaict.

And this is more of a feature request, would it not be possible to get rid of gtkiconsize as it's completely different in gtk4? If it's hardcoded upstreams in gtk3 you might as well hardcode it yourself? And get rid of gtk_icon_size_lookup in the process. But this is a huge rework that gets rid of basically everything that is already deprecated in gtk3, good work!!

Let's do that in bug 1965779.

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/eee332f4853b
https://hg.mozilla.org/mozilla-central/rev/5c3a64943da8
https://hg.mozilla.org/mozilla-central/rev/025d3cf31593

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db25c2152ea0
Use HiDPI symbolic icons for the titlebar. r=stransky,desktop-theme-reviewers,dao

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d122340fa854
Use HiDPI icons in preferences app list. r=settings-reviewers,Gijs

Comment 16

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/db25c2152ea0

Comment 17

[Goloman Adrian[:agoloman]]

https://hg.mozilla.org/mozilla-central/rev/d122340fa854