Closed Bug 196406 Opened 17 years ago Closed 17 years ago

Mozilla is sending an Accept-encoding for compress but doesn't support it.

Categories

(Core :: Networking: HTTP, defect)

defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: ddick, Assigned: darin.moz)

References

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030210
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030210

This bug was created because of comment 6 and 141 on bug 105292.  Mozilla sends
compress in the Accept-Encoding header but does not support it.

Reproducible: Always

Steps to Reproduce:
1. Point the browser at a new installation of apache to /cgi-bin/printenv
2. Examine the results on the screen

Actual Results:  
....
HTTP_ACCEPT_CHARSET="UTF-8,*"
HTTP_ACCEPT_ENCODING="gzip,deflate,compress;q=0.9"
HTTP_ACCEPT_LANGUAGE="en-au"
......

Expected Results:  
....
HTTP_ACCEPT_CHARSET="UTF-8,*"
HTTP_ACCEPT_ENCODING="gzip,deflate"
HTTP_ACCEPT_LANGUAGE="en-au"
.....
marking NEW.

simple fix - http://bugzilla.mozilla.org/attachment.cgi?id=65978&action=view is
the old patch for this from the other bug.
Status: UNCONFIRMED → NEW
Ever confirmed: true
This is a simple and effective fix. Can we apply this patch please?
Attached patch Patch v1.0Splinter Review
As per comment, adding patch from earlier bug which is meant to fix this bug.
Note: This does NOT mean that I'm taking on this bug, but rather that I'm just
helping with moving it along.

Adding 1.4a?
Flags: blocking1.4a?
well that patch has, technically, rotted - the pref that needs 10 characters
changed is actually now on line 572 of all.js.

I can't imagine that this would block an alpha release, given that the problem
has existed in all previous releases.

given the size of the change, all that's needed here is someone to rubberstamp
it and check in the change... Darin?
Comment on attachment 118415 [details] [diff] [review]
Patch v1.0

r+sr=darin

yeah, our support for the compress CE is definitely horked.  let's remove this
for alpha and see what if any problems occur.
Attachment #118415 - Flags: superreview+
Attachment #118415 - Flags: review+
actually, we previously accepted gzip and deflate equally.  i don't think we
should change that at this time.  besides, eliminating the ";q=0.9" will save us
a few more bytes per request =)

checked in
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
By the way, it was Vinay Badami who wrong the patch (see
http://bugzilla.mozilla.org/show_bug.cgi?id=105292#c13), not me. I just copied
it into this bug report.
AFAIK badami is gone
Flags: blocking1.4a?
right, badami isn't working on mozilla anymore :-(
quick visit to privacy.net shows my headers as:

Accept:
text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,video/x-mng,image/png,image/jpeg,image/gif;q=0.2,*/*;q=0.1
Accept-Language: en-gb,en-us;q=0.7,en;q=0.3
Connection: keep-alive
Host: www.privacy.net
Referer: http://www.privacy.net/
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4a) Gecko/20030329
Accept-Encoding: gzip,deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 300

marking verified.
Status: RESOLVED → VERIFIED
Blocks: 191676
You need to log in before you can comment on or make changes to this bug.