1964063 - Content process crash when resetting geolocation override if override was not set before

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect, P2)

Description

[Alexandra Borovova [:Sasha]]

While investigating a Playwright test failure, I've noticed that calling browsingContext.setGeolocationServiceOverride without arguments (to reset the override) without override being set causes a crash.

Comment 1

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1964063 - Try to reset a geolocation override only if it was set before.

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1964063 - [wdspec] Add test for "emulation.setGeolocationOverride" to reset the override without it being set.

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1962205

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1510d7495909
Try to reset a geolocation override only if it was set before. r=saschanaz
https://hg.mozilla.org/integration/autoland/rev/e5708b16fccf
[wdspec] Add test for "emulation.setGeolocationOverride" to reset the override without it being set. r=webdriver-reviewers,whimboo

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/52348 for changes under testing/web-platform/tests

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1510d7495909
https://hg.mozilla.org/mozilla-central/rev/e5708b16fccf

Comment 7

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1964063 - Try to reset a geolocation override only if it was set before.

Original Revision: https://phabricator.services.mozilla.com/D247601

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Geolocation override will cause a content process crash when resetting geolocation override if override was not set before
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: None
• Risk associated with taking this patch: Low
• Explanation of risk level: It only affects test automation scenarios
• String changes made/needed: None
• Is Android affected?: yes

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/62fce9055fdb