1964126 - Issues with displaying DPR value in Responsive Design Mode

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect, P2)

Description

[el8]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:138.0) Gecko/20100101 Firefox/138.0

Steps to reproduce:

Press Ctrl+Shift+M to enter Responsive Design Mode, click on "Responsive" at the top and select "Galaxy Note 20 Android 11" (the first item in the list). Notice that in the DPR area (outlined in red in the attached image):
a) The value is only partially seen ("2..." instead of the full value), and there doesn't seem to be a way to fully display it.
b) There are arrow_up and arrow_down controls which don't seem to do anything.

Comment 1

[el8]

Attachment: dpr.png

Comment 2

[el8]

b) There are arrow_up and arrow_down controls which don't seem to do anything.

In the description of Responsive Design Mode at firefox-source-docs.mozilla.org it's said that "Beginning with Firefox 68, the DPR is no longer editable". Perhaps the controls should not be displayed then so as not to confuse the user.

Comment 3

[Julian Descottes [:jdescottes]]

Thanks for the report. Indeed the preset prevents you from updating the DPR. This is not the case for the viewport size which can still be changed and will unselect the preset to go back to "Responsive".

So either we should do that: enable the controls and select responsive, or remove the UI which suggests that the DPR can be modified. One thing to note, the DPR select values are quite limited (1, 2, 3) and might not match what is in the preset. So we would need to use a similar widget to what is used for user agent.

P2 at least for fixing the display/ellipsis issue.

Comment 4

[Holger Benl [:hbenl]]

Attachment: Bug 1964126 - [devtools] Don't restrict width of DPR button in RDM. r=#devtools-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fad18a42942
[devtools] Don't restrict width of DPR button in RDM. r=devtools-reviewers,nchevobbe

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0fad18a42942