196442 - MSVC build fails without GNU binutils installed

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Frederic Bezies]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4a) Gecko/20030307
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4a) Gecko/20030307

This bug is driving me crazy. I cannot build anymore mozilla. It breaks during
configure.

Build process worked until today, before the huge amount of checkins for bug 134113.

Reproducible: Always

Steps to Reproduce:
1.Grab a tarball
2.Apply all CVS patches
3.Try to launch build process.

Actual Results:  
Process kills itself, saying :

"configure:error: Building crypto support requires a valid version of the
standalone assembler, ml.exe"

Expected Results:  
Building mozilla !

I am using the same building environment for nearly a month, and I made everyday
a working build !

Here are the option of my .mozconfig file :

ac_add_options --without-system-jpeg
ac_add_options --without-system-zlib
ac_add_options --enable-extensions
ac_add_options --enable-crypto

ac_add_options --disable-debug
ac_add_options --enable-optimize
ac_add_options --enable-calendar
ac_add_options --disable-pedantic
ac_add_options --disable-installer
ac_add_options --enable-strip

I also have a building log. Last line is saying "checking for mmintrin.h... no",
but I do have this file in include directory of my VC++ installation.

Comment 1

[Frederic Bezies]

Attachment: Building log before crash.

Comment 2

[cls]

Can you attach the config.log file as well?  

checking for as... no

It's not finding ml.exe in the current path.  

Comment 3

[Frederic Bezies]

Well.

This is weird, but when I installed MinGW32, build process work until its
"normal" end !

Modifying summary.

Comment 4

[cls]

That is weird as I'm fairly certain that none of the tinderbox have mingw
installed.  I guess I'll try uninstalling mingw locally to see what happens.

Comment 5

[cls]

Ok, for some odd reason, |AC_PATH_PROGS| isn't automatically checking for $AS
like the subsequent |AC_CHECK_PROGS| macros are so it doesn't check for ml. 
Hrm, digging through the macro definitions, it seems as though AC_PATH_PROG[S]
does an absolute path check before accepting the variable. 

It turns out that the tinderboxes have cygwin's binutils installed which is why
the test passed there.

Comment 6

[cls]

I just checked in the following fix: 

-    AC_PATH_PROGS(AS, as, $CC)
+    AC_PATH_PROGS(AS, $AS as, $CC)

Try pulling configure and rebuilding without mingw in your path.

Comment 7

[Frederic Bezies]

I removed c:\MinGW from my path, and it works.

This patch seems to cure the bug. Build process is going on. I am waiting to see
for its "normal" end, but I think you can close this bug as fixed.

Thanks.

Comment 8

[Frederic Bezies]

Ok. It's working.

Marking as fixed.

Comment 9

[Tracy Walker [:tracy]]

verified