1964446 - third_party/sqlite3/ext/sqlite-vec/sqlite-vec.c:68:9: error: unknown type name ‘u_int8_t’; did you mean ‘uint8_t’?

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Patrycja Rosa [:ptrcnull] (she/her)]

exactly the same as bug 1962061, but on Linux with musl libc; filing a separate bug as per :mak's comment

Steps to reproduce:

• try to build latest Firefox Nightly on Alpine Linux

0:36.93 /tmp/src/firefox-552e1f0e335136610af42fdcc57a92d3bae857ba/third_party/sqlite3/ext/sqlite-vec/sqlite-vec.c:68:9: error: unknown type name 'u_int8_t'; did you mean 'uint8_t'?
0:36.93    68 | typedef u_int8_t uint8_t;
0:36.93       |         ^~~~~~~~
0:36.93       |         uint8_t
0:36.93 /usr/include/bits/alltypes.h:121:25: note: 'uint8_t' declared here
0:36.93   121 | typedef unsigned char   uint8_t;
0:36.93       |                         ^
0:36.93 /tmp/src/firefox-552e1f0e335136610af42fdcc57a92d3bae857ba/third_party/sqlite3/ext/sqlite-vec/sqlite-vec.c:69:9: error: unknown type name 'u_int16_t'; did you mean 'uint16_t'?
0:36.93    69 | typedef u_int16_t uint16_t;
0:36.93       |         ^~~~~~~~~
0:36.93       |         uint16_t
0:36.93 /usr/include/bits/alltypes.h:126:25: note: 'uint16_t' declared here
0:36.93   126 | typedef unsigned short  uint16_t;
0:36.93       |                         ^
0:36.93 /tmp/src/firefox-552e1f0e335136610af42fdcc57a92d3bae857ba/third_party/sqlite3/ext/sqlite-vec/sqlite-vec.c:70:9: error: unknown type name 'u_int64_t'; did you mean 'uint64_t'?
0:36.93    70 | typedef u_int64_t uint64_t;
0:36.93       |         ^~~~~~~~~
0:36.93       |         uint64_t
0:36.93 /usr/include/bits/alltypes.h:136:25: note: 'uint64_t' declared here
0:36.93   136 | typedef unsigned _Int64 uint64_t;
0:36.93       |                         ^

also, opened upstream pull request to remove the typedefs entirely, and i believe that's also the correct course of action for the vendored version to fix build failures on musl.

Comment 1

[Patrycja Rosa [:ptrcnull] (she/her)]

Attachment: Bug 1964446 - Fix sqlite-vec build on Linux+musl.r=asuth

see also:
https://phabricator.services.mozilla.com/D247229#8557917
https://github.com/asg017/sqlite-vec/pull/219

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98761001f9bd
Fix sqlite-vec build on Linux+musl.r=asuth,mak

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/98761001f9bd