1964730 - [composable toolbar] Configure the toolbar for custom tabs support

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

We should use the BrowserToolbarMiddleware used for configuring the toolbar in normal tabs as an example for configurin the toolbar UX for custom tabs also.
The resulted UX should fully match the current one for the toolbar View, including the support for custom theming based on the incoming custom tabs configuration.
(More details to be added later)

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1964730 - part 1 - Code cleanup: Refactor out context dependency of CookieBannersStorage.getCookieBannerUIMode r=#android-reviewers

Going by the principle of least knowledge the context dependency that leads
to a long chain of dependencies readings can be replaced with the exact data
the system needs.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1964730 - part 2 - Allow the url in the composable toolbar to be configured without click handling r=#android-reviewers

When in custom tabs nothing should happen when the url is clicked, not even
a haptic event.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1964730 - part 3 - Configure the composable toolbar in custom tabs r=#android-reviewers

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1964730 - part 6 - Support custom tabs custom colors r=#android-reviewers

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1964730 - part 4 - Necessary composable toolbar updates to support Fenix buttons r=#android-reviewers

For custom tabs Fenix might want to show buttons with custom drawables
with default tinting enabled or disabled.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1964730 - part 5 - Use custom back and action buttons if configured for the custom tab r=#android-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3010472d6e90
https://hg.mozilla.org/integration/autoland/rev/11f1927f795b
part 1 - Code cleanup: Refactor out context dependency of CookieBannersStorage.getCookieBannerUIMode r=android-reviewers,tchoh,skhan

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/11f1927f795b

Comment 9

[Petru-Mugurel Lingurar [:petru]]

We have a few more things to land.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/49e4e2364616
https://hg.mozilla.org/integration/autoland/rev/9f93b2bd0ac1
part 2 - Allow the url in the composable toolbar to be configured without click handling r=android-reviewers,tchoh
https://github.com/mozilla-firefox/firefox/commit/21ddb83c8eac
https://hg.mozilla.org/integration/autoland/rev/102109dfef21
part 3 - Configure the composable toolbar in custom tabs r=android-reviewers,skhan
https://github.com/mozilla-firefox/firefox/commit/ec230891ddf4
https://hg.mozilla.org/integration/autoland/rev/b28f8c1cf241
part 4 - Necessary composable toolbar updates to support Fenix buttons r=android-reviewers,Roger
https://github.com/mozilla-firefox/firefox/commit/fecd20910ae4
https://hg.mozilla.org/integration/autoland/rev/7c5f0062c211
part 5 - Use custom back and action buttons if configured for the custom tab r=android-reviewers,Roger
https://github.com/mozilla-firefox/firefox/commit/15b89ec032a0
https://hg.mozilla.org/integration/autoland/rev/a98301eace8c
part 6 - Support custom tabs custom colors r=android-reviewers,007

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9f93b2bd0ac1
https://hg.mozilla.org/mozilla-central/rev/102109dfef21
https://hg.mozilla.org/mozilla-central/rev/b28f8c1cf241
https://hg.mozilla.org/mozilla-central/rev/7c5f0062c211
https://hg.mozilla.org/mozilla-central/rev/a98301eace8c