1964905 - Events for user prompts opened or closed within an iframe do not reference the iframe's context ID

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The tests were updated on bug 1963047. We should fix this bug.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1964905 - [wdspec] Update meta data for user prompt tests within an iframe.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf71f38a0f8a
[wdspec] Update meta data for user prompt tests within an iframe. r=webdriver-reviewers,Sasha

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

My patch only updated the manifest file for the correct bug id. I'm not working on a fix right now.

For a fix it would be good to know if there is any property on the prompt which would allow us to retrieve the origin window which opened it.

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/bf71f38a0f8a

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We need to check if the reference to the frame's window is already accessible or not. Let me check that next week.

Comment 6

[Alexandra Borovova [:Sasha]]

I did some investigation here, and I don't think we have at the moment any information about the window/browsing context which opened this prompt in the notification we listened to or prompt object which we receive or can find in the target browser. But I think we can add this information in https://searchfox.org/firefox-main/source/toolkit/components/prompts/src/CommonDialog.sys.mjs#228 for desktop, because this.args contains owningBrowsingContext property which is the browsing context which opened the prompt. For GeckoView there seems to be info about browsing context here: https://searchfox.org/firefox-main/source/mobile/shared/components/geckoview/GeckoViewPrompter.sys.mjs#29, but it also has to be passed down to the right place. Additionally, we will have to refactor https://searchfox.org/firefox-main/source/remote/shared/listeners/PromptListener.sys.mjs#139-214 to work with it, but it can probably be simplified in the end.
So overall I think it should be possible to implement, but we should probably bump it to 5 points.

Comment 7

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1964905 - Add "owningBrowsingContext" to "DOMModalDialogClosed" event details.

Comment 8

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1964905 - [geckoview] Add "owningBrowsingContext" to "DOMModalDialogClosed" event details and to "geckoview-prompt-show" notification.

Comment 9

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1964905 - [webdriver-bidi] Use "owningBrowsingContext" to handle prompts.

Comment 10

[Alexandra Borovova [:Sasha]]

The Android part is moved to bug 2007385.

Comment 11

[Phabricator Automation]

Comment on attachment 9533601 [details]
Bug 1964905 - [geckoview] Add "owningBrowsingContext" to "DOMModalDialogClosed" event details and to "geckoview-prompt-show" notification.

Revision D276820 was moved to bug 2007385. Setting attachment 9533601 [details] to obsolete.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fc11ba2f78f9
https://hg.mozilla.org/integration/autoland/rev/174dc41b0d15
Add "owningBrowsingContext" to "DOMModalDialogClosed" event details. r=Gijs
https://github.com/mozilla-firefox/firefox/commit/ff08bedebcc8
https://hg.mozilla.org/integration/autoland/rev/2e7073623e3a
[webdriver-bidi] Use "owningBrowsingContext" to handle prompts. r=whimboo

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/174dc41b0d15
https://hg.mozilla.org/mozilla-central/rev/2e7073623e3a