Closed Bug 1964923 Opened 1 year ago Closed 1 year ago

Tab groups still move vertically when using expand on hover with vertical tabs on Windows and Linux

Categories

(Firefox :: Tabbed Browser, defect, P1)

Firefox 140
defect
Points:
2

Tracking

()

VERIFIED FIXED
140 Branch
Tracking Status
firefox-esr128 --- disabled
firefox138 --- wontfix
firefox139 --- wontfix
firefox140 --- verified

People

(Reporter: patrice.grundmann, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-tabgrps-vertical])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:140.0) Gecko/20100101 Firefox/140.0

Steps to reproduce:

  • Add some tabs in Firefox Nightly
  • Add some containers (with Firefox Account Containers add-on)
  • Add some tabs in containers created
  • Add some tabs groups and put some tab into them

Actual results:

The hover effect since it appear (the 20 march) in Nightly is very disturbing. Visual focus is lost between the favicon (with the tab folded) and its unfolded version, when there's a hover effect on the favicon.

Expected results:

The expected behavior, if there is already the possibility of visually finding one's way around tabs, would be that the display should be identical and persist regardless of whether the tabs are “open” or “closed”. Take a look at Microsoft Edge to see for yourself.

Here is the bug in a image (two screencaps). I have drawn yellow dotted lines to visualise the problem.
Here is the gap example: https://ibb.co/xqBbYrbF
And https://ibb.co/NDDSbNV

The bug is releated to: https://bugzilla.mozilla.org/show_bug.cgi?id=1956394

Blocks: 1907534
Severity: -- → S3
Points: --- → 2
Depends on: 1956394
Priority: -- → P2
See Also: → 1964442
Whiteboard: [fidefe-tabgrps-vertical]
Summary: Bug again: Tab groups are misaligned when using expand on hover with vertical tabs → Tab groups can still be misaligned when using expand on hover with vertical tabs

The Bugbug bot thinks this bug should belong to the 'Firefox::Sidebar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Sidebar

I can reproduce on Linux as well. Might be harder to reproduce on macOS as it likely depends on the system font size.

Assignee: nobody → dao+bmo
Blocks: 1964442
Status: UNCONFIRMED → ASSIGNED
Component: Sidebar → Untriaged
Ever confirmed: true
See Also: 1964442
Summary: Tab groups can still be misaligned when using expand on hover with vertical tabs → Tab groups still move vertically when using expand on hover with vertical tabs on Windows and Linux
Component: Untriaged → Theme
Component: Theme → Tabbed Browser

Upgrading priority to match bug 1956394.

Priority: P2 → P1
No longer blocks: 1964442
Duplicate of this bug: 1964442
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/76e2e0a1877e Make tab group label layout more consistent between collapsed and expanded vertical tabs so that things don't move around vertically when expanding on hover. r=sthompson,tabbrowser-reviewers
Flags: qe-verify+
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 140 Branch

This issue is Verified as fixed in our latest Nightly 140.0a1 (2025-05-12)

QA Whiteboard: [qa-ver-needed-c140/b139]
QA Contact: rdoghi

The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(dao+bmo)
Flags: needinfo?(dao+bmo)

Updating the remaining flags.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-ver-needed-c140/b139] → [qa-ver-done-c140/b139]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: