1965029 - Implement color input value attribute as any CSS color

Status: RESOLVED FIXED

(Core :: DOM: Forms, enhancement)

Description

[Luke Warlow]

Currently the color input in Gecko only supports hex values in the value attribute of color inputs. The HTML spec has been updated to allow any valid CSS color to be used.

This was added alongside the alpha and colorspace attributes but imo would be a useful addition on its own.

This requires updating HTMLInputElement to use Servo to validate, parse and serialize the value attribute as appropriate. For now the serialization would act as if alpha attribute was missing and colorspace had its default of limited-srgb. This would result in the output still always being a standard hex.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1965029 - Accept CSS color syntax in `input type=color` r=emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f360400c2978
https://hg.mozilla.org/integration/autoland/rev/6a746ced3601
Accept CSS color syntax in `input type=color` r=emilio

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/54057 for changes under testing/web-platform/tests

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/89e73abd8bfa
https://hg.mozilla.org/integration/autoland/rev/0f494becca08
Revert "Bug 1965029 - Accept CSS color syntax in `input type=color` r=emilio" for causing mochitest failures on test_input_color_picker_datalist.html

Comment 5

[Cristina Horotan [:chorotan]]

Backed out for causing mochitest failures

Backout link

Push with failures

Failure log

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bf673891ceb2
https://hg.mozilla.org/integration/autoland/rev/6274aba2b695
Accept CSS color syntax in `input type=color` r=emilio

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/54091 for changes under testing/web-platform/tests

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6274aba2b695

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for the Fx143 relnotes?

Comment 13

[Kagami Rosylight [:saschanaz] (they/them)]

I was wondering that... let's do it.

Release Note Request (optional, but appreciated)
[Why is this notable]: The color form control now accepts a broader syntax
[Affects Firefox for Android]: Yes
[Suggested wording]: <input type=color> now recognizes CSS <color> format in addition to the color hex format (#ffffff). This means color names like black and more complex string like rgb(200 200 200) is now a valid input. For now the value will always be converted to the hex format.
[Links (documentation, blog post, etc)]:

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx143 relnotes, thanks.