1965053 - Warning spam from abseil numbers.cc

Status: NEW

(Firefox Build System :: General, defect, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Local build seeing lots of comma operator warnings (linux, debug browser build)

 0:04.48 /home/matthew/unified-git/third_party/abseil-cpp/absl/strings/numbers.cc:453:27: warning: possible misuse of comma operator here [-Wcomma]
 0:04.48   453 |     if (d < 1e+2) exp -= 4, d *= 1e4;
 0:04.48       |                           ^
 0:04.49 /home/matthew/unified-git/third_party/abseil-cpp/absl/strings/numbers.cc:453:19: note: cast expression to void to silence warning
 0:04.49   453 |     if (d < 1e+2) exp -= 4, d *= 1e4;
 0:04.49       |                   ^~~~~~~~
 0:04.49       |                   static_cast<void>( )
 0:04.49 /home/matthew/unified-git/third_party/abseil-cpp/absl/strings/numbers.cc:454:27: warning: possible misuse of comma operator here [-Wcomma]
 0:04.49   454 |     if (d < 1e+4) exp -= 2, d *= 1e2;
 0:04.49       |                           ^
 0:04.49 /home/matthew/unified-git/third_party/abseil-cpp/absl/strings/numbers.cc:454:19: note: cast expression to void to silence warning
 0:04.49   454 |     if (d < 1e+4) exp -= 2, d *= 1e2;
 0:04.49       |                   ^~~~~~~~
 0:04.49       |                   static_cast<void>( )
 0:04.49 /home/matthew/unified-git/third_party/abseil-cpp/absl/strings/numbers.cc:455:27: warning: possible misuse of comma operator here [-Wcomma]
 0:04.49   455 |     if (d < 1e+5) exp -= 1, d *= 1e1;
 0:04.49       |                           ^
 0:04.49 /home/matthew/unified-git/third_party/abseil-cpp/absl/strings/numbers.cc:455:19: note: cast expression to void to silence warning
 0:04.49   455 |     if (d < 1e+5) exp -= 1, d *= 1e1;
 0:04.49       |                   ^~~~~~~~
 0:04.49       |                   static_cast<void>( )
 0:04.49 /home/matthew/unified-git/third_party/abseil-cpp/absl/strings/numbers.cc:581:33: warning: possible misuse of comma operator here [-Wcomma]
 0:04.49   581 |       memcpy(out, &digits[0], 6), out += 6;
 0:04.50       |                                 ^
 0:04.50 /home/matthew/unified-git/third_party/abseil-cpp/absl/strings/numbers.cc:581:7: note: cast expression to void to silence warning
 0:04.50   581 |       memcpy(out, &digits[0], 6), out += 6;
 0:04.50       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~
 0:04.50       |       static_cast<void>(        )
 0:04.50 /home/matthew/unified-git/third_party/abseil-cpp/absl/strings/numbers.cc:585:33: warning: possible misuse of comma operator here [-Wcomma]
 0:04.50   585 |       memcpy(out, &digits[0], 5), out += 5;
 0:04.50       |                                 ^
 0:04.50 /home/matthew/unified-git/third_party/abseil-cpp/absl/strings/numbers.cc:585:7: note: cast expression to void to silence warning
 0:04.50   585 |       memcpy(out, &digits[0], 5), out += 5;
 0:04.50       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~
 0:04.50       |       static_cast<void>(        )
 0:04.50 /home/matthew/unified-git/third_party/abseil-cpp/absl/strings/numbers.cc:593:33: warning: possible misuse of comma operator here [-Wcomma]
 0:04.50   593 |       memcpy(out, &digits[0], 4), out += 4;

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

(There's other abseil warnings too:

0:05.01 In file included from /home/matthew/unified-git/third_party/abseil-cpp/absl/synchronization/internal/futex_waiter.h:24:
 0:05.01 /home/matthew/unified-git/third_party/abseil-cpp/absl/synchronization/internal/futex.h:159:30: warning: result of comparison 'const __time_t' (aka 'const long') > 9223372036854775807 is always false [-Wtautological-type-limit-compare]
 0:05.01   159 |     if (userspace_ts->tv_sec > kMaxSeconds) {
 0:05.01       |         ~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~
 0:05.01 In file included from Unified_cpp_synchronization_gn0.cpp:83:
 0:05.02 /home/matthew/unified-git/third_party/abseil-cpp/absl/synchronization/mutex.cc:878:29: warning: possible misuse of comma operator here [-Wcomma]
 0:05.02   878 |     while ((x0 = x1, x1 = x2, x2 = x2->skip) != nullptr) {
 0:05.02       |                             ^
 0:05.02 /home/matthew/unified-git/third_party/abseil-cpp/absl/synchronization/mutex.cc:878:22: note: cast expression to void to silence warning
 0:05.02   878 |     while ((x0 = x1, x1 = x2, x2 = x2->skip) != nullptr) {
 0:05.02       |                      ^~~~~~~
 0:05.02       |                      static_cast<void>( )
 0:05.02 /home/matthew/unified-git/third_party/abseil-cpp/absl/synchronization/mutex.cc:878:20: warning: possible misuse of comma operator here [-Wcomma]
 0:05.02   878 |     while ((x0 = x1, x1 = x2, x2 = x2->skip) != nullptr) {
 0:05.02       |                    ^
 0:05.02 /home/matthew/unified-git/third_party/abseil-cpp/absl/synchronization/mutex.cc:878:13: note: cast expression to void to silence warning
 0:05.02   878 |     while ((x0 = x1, x1 = x2, x2 = x2->skip) != nullptr) {
 0:05.02       |             ^~~~~~~
 0:05.02       |             static_cast<void>( )