1965549 - Intermittent netwerk/test/unit/test_bug1378385_http1.js | single tracking bug

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Treeherder Bug Filer]

Filed by: brennie [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=507237219&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/OCfFKv6kT4m8AdVlB_I-ag/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Beth Rennie [:beth] (she/her)]

netwerk/cookie/test/unit/test_migrateCookieLifetimePref.js | xpcshell return code: 0
netwerk/test/unit/test_bug1378385_http1.js | xpcshell return code: 0
netwerk/test/unit/test_bug1378385_http1.js | check_response_id - [check_response_id : 130] "123" == 126
widget/windows/tests/unit/test_windows_alert_service.js | xpcshell return code: 0
widget/windows/tests/unit/test_windows_alert_service.js |  - when notification server pref is unset - ["<toast launch=\\"launch\\"><visual><binding template=\\"ToastText03\\"><text id=\\"1\\">title</text><text id=\\"2\\">text</text></binding></visual><actions><action content=\\"Notification settings\\"/></actions></toast>",{"launch":{"invalid key":"invalid value","action":"{\\"action\\":\\"\\"}"},"actions":{"Notification
[taskcluster:error] exit status 2

I was backed out for this in bug 1957513 but I believe this might be a ~perma fail that is intermittently passing? It is failing for me (and :edgul) on main.

Comment 2

[Cosmin Sabou [:CosminS]]

This is green on central/main, link here. The changes in https://bugzilla.mozilla.org/show_bug.cgi?id=1957513#c14 cause this to permafail, proof here.

Comment 3

[Beth Rennie [:beth] (she/her)]

This is still failing locally. The necko team should investigate

Comment 4

[Beth Rennie [:beth] (she/her)]

If you run the entire test suite, the test seems to pass. When you run the test in isolation, it fails 100% of the time

Comment 5

[Kershaw Chang [:kershaw]]

The issue is that in nsHttpHandler::PrefsChanged, we don't update mActiveTabPriority when the network.http.active_tab_priority changes.
As a result, this line becomes a no-op.

Comment 6

[Kershaw Chang [:kershaw]]

Attachment: Bug 1965549 - Migrate network.http.active_tab_priority to static prefs, r=#necko

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd7d2f62831a
Migrate network.http.active_tab_priority to static prefs, r=necko-reviewers,valentin

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28ac2b5b931a
Revert "Bug 1965549 - Migrate network.http.active_tab_priority to static prefs, r=necko-reviewers,valentin" for causing build bustages at PendingTransactionQueue.cpp

Comment 9

[Cristina Horotan [:chorotan]]

Backed out for causing bustage at PendingTransactionQueue.cpp

Backout link

Push with failures

Failure log

Comment 10

[Kershaw Chang [:kershaw]]

https://treeherder.mozilla.org/jobs?repo=try&revision=b5e3aa3693db3858ca32bcb246d541f61e1d134d

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/021dcff34b1a
Migrate network.http.active_tab_priority to static prefs, r=necko-reviewers,valentin

Comment 12

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/021dcff34b1a