Closed
Bug 1965556
Opened 9 months ago
Closed 7 months ago
intel_aes_gcmDEC x86 asm doesn't have proper frame pointers
Categories
(NSS :: Libraries, defect, P3)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jrmuizel, Unassigned)
Details
Attachments
(1 file)
https://searchfox.org/mozilla-central/source/security/nss/lib/freebl/intel-gcm-x64-masm.asm#948
This prevents us from unwinding the stack with frame pointers when profiling.
|
Reporter | |
Updated•9 months ago
|
Summary: intel_aes_gcm_DEC x86 asm doesn't have proper frame pointers → intel_aes_gcmDEC x86 asm doesn't have proper frame pointers
|
||
Comment 1•7 months ago
|
||
Are you sure that intel-gcm-x64-masm.asm is the right file? When I break on intel_aes_gcmDEC in gdb I end up in intel-gcm.s. I have a patch for intel-gcm.s, but I wanted to double-check whether I need to patch intel-gcm-x64-masm.asm as well.
Severity: -- → S4
Priority: -- → P3
|
|
Reporter | |
Comment 2•7 months ago
|
||
I'm not certain. When is intel-gcm-x64-masm.asm used?
Flags: needinfo?(jschanck)
|
|
||
Comment 3•7 months ago
|
||
|
|
||
Comment 4•7 months ago
|
||
Looks like we use intel-gcm-x64-masm.asm when we build with MSVC. I'm not set up to build with MSVC so I'm inclined not to touch it.
Flags: needinfo?(jschanck)
|
|
||
Comment 5•7 months ago
|
||
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•