1965561 - Newtab custom wallpapers not updating startup cache

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Comment 1

[Amber Meryman]

Regardless of version, if the Startup setting “Open previous windows and tabs” is selected, the Custom Wallpaper is shown on first New Tab.
If it’s not selected, it is not shown on the first (but is shown on subsequent).

1. Add a Custom Wallpaper
2. Restart the browser (close, re-open)
3. On the first New Tab, the wallpaper will not be there. On subsequent New Tabs, it will.
   Again, depending on that setting.

Comment 2

[Scott [:thecount] Downe]

Attachment: Bug 1965561 - Newtab custom wallpapers startup cache fix

Comment 3

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: This is an issue in 139 and 140.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6c65b0dc4ce
Newtab custom wallpapers startup cache fix r=home-newtab-reviewers,nbarrett,mconley

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/d6c65b0dc4ce

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:thecount, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox139 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Scott [:thecount] Downe]

Attachment: Bug 1965561 - Newtab custom wallpapers startup cache fix

Original Revision: https://phabricator.services.mozilla.com/D248689

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Delay in release custom wallpapers to users
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Steps to test in bug
• Risk associated with taking this patch: Low
• Explanation of risk level: We have built the patch so 90% of the risk is asociated with custom wallpapers which is not shipped and would not ship anyway without this uplift, the changes that have a chance to impact the default experience are minimal and very low. This is because the addition of StartupCacheInit.sys.mjs is only applied to custom wallpapers. We are going to do a followup patch that adds some more to that file, but that is happening in nightly.
• String changes made/needed: None
• Is Android affected?: no

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/c8b7f4e4a8f9

Comment 10

[Alice Varro [avarro], Ecosystem QA]

I have verified this issue using Firefox Nightly 140.0a1 (Build id: 20250513214736) and Firefox Beta 139.0b8 (Build id: 20250514023146) - downloaded from treeherder on Windows 10 x64, macOS 14.5 and Ubuntu 22.04 LTS and I can confirm that by following the steps from Comment 1 the issue is no longer reproducible. The Custom wallpaper is successfully displayed on the first New Tab after reopening/restarting the browser even if the “Open previous windows and tabs” is selected or not.