Closed
Bug 1965714
Opened 1 month ago
Closed 1 month ago
queryInfo parameter to `tabGroups.query` should be marked as required, not optional
Categories
(WebExtensions :: General, task, P2)
WebExtensions
General
Tracking
(firefox140 fixed)
RESOLVED
FIXED
140 Branch
| Tracking | Status | |
|---|---|---|
| firefox140 | --- | fixed |
People
(Reporter: robwu, Assigned: robwu)
References
Details
(Whiteboard: [addons-jira])
Attachments
(1 file)
tabGroups.query requires a query object. This parameter is currently marked as optional in the JSON schema: https://searchfox.org/mozilla-central/rev/7a33d9702cfb059f19ece355416b58d6cfbd8093/browser/components/extensions/schemas/tabGroups.json#133
But the query cannot be omitted. It is required in Chrome for example: https://developer.chrome.com/docs/extensions/reference/api/tabGroups#method-query
A similar method, tabs.query, also requires the parameter. Note the missing "optional": true at https://searchfox.org/mozilla-central/rev/7a33d9702cfb059f19ece355416b58d6cfbd8093/browser/components/extensions/schemas/tabs.json#730-732
|
||
Updated•1 month ago
|
|
Assignee | |
Comment 1•1 month ago
|
||
|
||
Updated•1 month ago
|
Assignee: nobody → rob
Status: NEW → ASSIGNED
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/babda4038549
Drop optional from queryInfo in tabGroups.query() r=zombie
|
||
Updated•1 month ago
|
Severity: -- → N/A
Priority: -- → P2
|
||
Comment 3•1 month ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox140:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 140 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•