1965739 - Library toolbar buttons missing drop arrows and icons on Windows

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Sam Johnson]

The Library toolbar menus on Windows recently lost their drop arrows and icons due to menu refactors.

Comment 1

[Sam Johnson]

Attachment: Bug 1965739 - Fix missing Library toolbar arrows and icons on Windows. r?emilio

Restore the drop arrow by borrowing the Linux implementation, and restore the icons.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1959540

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e93b875d1bf
Fix missing Library toolbar arrows and icons on Windows. r=emilio,desktop-theme-reviewers

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/6e93b875d1bf

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sam, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox139 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Sam Johnson]

Attachment: Bug 1965739 - Fix missing Library toolbar arrows and icons on Windows. r?emilio

Restore the drop arrow by borrowing the Linux implementation, and restore the icons.

Original Revision: https://phabricator.services.mozilla.com/D248731

Comment 7

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: User confusion when attempting to use the toolbar menus in the Library window, as they won't look like menus
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: On Windows, open the app menu > Bookmarks > Manage bookmarks. In the toolbar at the top of the Library window, there should be icons and dropdown arrows for the menus.
• Risk associated with taking this patch: Low
• Explanation of risk level: Minor CSS change
• String changes made/needed: None
• Is Android affected?: no

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/4b7b1d293f7a

Comment 9

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Reproduced the issue on Firefox 140.0a1 (2025-05-11) on Windows 11 by following the info provided in Comment 0.

The issue is fixed on Firefox 139.0b8 (treeherder build) and Firefox 140.0a1 (2025-05-13) on the same system.