1965832 - Remove static mocking of org.mozilla.fenix.ext.BookmarkNodeKt used in BookmarkItemMenuTest

Status: RESOLVED FIXED

(Firefox for Android :: Bookmarks, task)

Description

[Mihai Adrian Carare [:mcarare]]

We should extract bookmarks child checking into a separate method to remove static mocking of org.mozilla.fenix.ext.BookmarkNodeKt.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox for Android::Bookmarks' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1965832 - Add a `checkAtLeastOneChild` method and inject bookmarksStorage to improve testability of menu item creation.

This commit also refactors the code generating the bookmark item menu to be more readable:

• Replace listOfNotNull with buildList for creating the menu options.
• Introduce helper variables for each menu option.

Comment 3

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1965832 - Add a test to ensure checkAtLeastOneChild is not called for SEPARATOR and ITEM types

The checkAtLeastOneChild function is only relevant for BookmarkNodeType.FOLDER. This change ensures the function is not called unnecessarily for other types.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59c36992320d
Add a `checkAtLeastOneChild` method and inject bookmarksStorage to improve testability of menu item creation. r=android-reviewers,pollymce

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/59c36992320d