1966000 - If user does not have a device lock setup, clicking on Lock Tabs in the Tabs tray banner should take them to the PBM Settings

Status: VERIFIED FIXED

(Firefox for Android :: Privacy, defect)

Description

[:Gela]

If user already has a device lock setup and ready to go, clicking "Lock tabs" locks the tabs. This already works as expected.

However, if user does not have a device lock set up, clicking on Lock Tabs in the Tabs tray banner should take them to the PBM Settings where they see the greyed out toggle option with a link to the device settings to setup a device lock.
Figma flow for this: https://www.figma.com/design/qiiSyigCsqDx9kNyxcGEev/BioAuth?node-id=801-10777&t=M7SObywiN6QpGsjX-4

Comment 1

[twhite]

Attachment: Bug 1966000 - Part 1: Update PBM lock settings to handle, When the device does not have the capability and when the device does have capability but lock is disabled

Comment 2

[twhite]

Attachment: Bug 1966000 - Part 2: Update the PBM banner to handle when the device capability is disabled or not available.

Comment 3

[twhite]

Attachment: Bug 1966000 - Part 3: Add comment for updatePreferences in onResume() in PrivateBrowsingFragment

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcad90e4032c
Part 1: Update PBM lock settings to handle, When the device does not have the capability and when the device does have capability but lock is disabled r=android-reviewers,android-l10n-reviewers,delphine,gmalekpour
https://hg.mozilla.org/integration/autoland/rev/16ffcacb5526
Part 2: Update the PBM banner to handle when the device capability is disabled or not available. r=android-reviewers,gmalekpour
https://hg.mozilla.org/integration/autoland/rev/9c46cfd6dfed
Part 3: Add comment for updatePreferences in onResume() in PrivateBrowsingFragment r=android-reviewers,gmalekpour

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/bcad90e4032c
https://hg.mozilla.org/mozilla-central/rev/16ffcacb5526
https://hg.mozilla.org/mozilla-central/rev/9c46cfd6dfed

Comment 6

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: DeviceSettings.mp4

Tested this implementation on Firefox for Android Nightly 140 (2025-05-19) under Samsung S24 Ultra (Android 14) and Google Pixel 8 (Android 15) and when the user taps on "Lock Tabs" option it is taken to the lock screen device settings instead of Private Browsing Settings from Firefox. This issue is tracked in Bug 1967427.