1966166 - Listen for locale and other context changes on Desktop

Status: RESOLVED FIXED

(Application Services :: Remote Settings, task)

Description

[Ben Dean-Kawamura [:bdk]]

As part of https://bugzilla.mozilla.org/show_bug.cgi?id=1956519, we listen for changes to the country code and update the remote settings context based on that. We should extend this to listen for other changes, in particular the locale.

Comment 1

[Mark Banner (:standard8)]

I think locale is the only other thing that we need to listen for. This can be done by observing intl:app-locales-changed.

Comment 2

[Mark Banner (:standard8)]

The interesting detail here might be that we would need to make sure that if clients are also listening to intl:app-locales-changed that they update after the remote settings server has updated. Hence it might be wise to send out a notification after remote settings has updated, indicating that the environment has changed, and they may wish to update if necessary.

Comment 3

[Drew Willcoxon :adw]

I'll take this -- I'm working on a Suggest test that changes the region and locale and ingests Suggest data several times, which means the locale in the shared RS service needs to be updated.

Comment 4

[Drew Willcoxon :adw]

Attachment: Bug 1966166 - Update the Rust SharedRemoteSettingsService on locale changes.

In addition to fixing the bug, this also makes sure we don't use a
cannot-be-a-base URL for the server during tests. I added a comment about that.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/04eed55db9c3
https://hg.mozilla.org/integration/autoland/rev/baa25f56dc6a
Update the Rust SharedRemoteSettingsService on locale changes. r=bdk

Comment 6

[Atila Butkovits]

Backed out for causing failures at test_RustSharedRemoteSettingsService.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/e53ce5540bdf680a53de9bb0b03b411f2ca992b9

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=04f1335cc821d299065145b9340183a4ff82d68c&selectedTaskRun=W1mYX1TNTiqyu_6kHTBYlA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=531208726&repo=autoland&task=W1mYX1TNTiqyu_6kHTBYlA.0&lineNumber=2117

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9533b94cc4ee
https://hg.mozilla.org/integration/autoland/rev/dfef9d82a9fe
Update the Rust SharedRemoteSettingsService on locale changes. r=bdk

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/dfef9d82a9fe