1966184 - RFPTarget::ScreenAvailToSize should handle fullscreen status

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P3)

Description

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

See comment 17 until 20 for the discussion in bug 1954194. In summary, we probably want to return different numbers when we are in fullscreen mode.

Comment 1

[Pier Angelo Vendrame]

Thanks for opening this bug!
I've already worked on this for Bug 1591337, here is my WIP branch: https://github.com/PieroV/firefox/tree/1591337-spoof-outer-realistic-size.
I think I can send a partial patch to cover this Bug if it's okay for you 😄.

Comment 2

[Pier Angelo Vendrame]

I sent the same code also in https://phabricator.services.mozilla.com/D249534.

Comment 3

[Tom Ritter [:tjr]]

Attachment: Bug 1966184: If we are fullscreen, do not subtract anything from the available resolution r?fkilic

Comment 4

[Tom Ritter [:tjr]]

I've tested the patch on Android, Linux, and both types of mac fullscreen and it works as expected; I'm going to try and get this into 140 so we're not delayed a cycle on experimenting.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c60ed4ebccce
If we are fullscreen, do not subtract anything from the available resolution r=fkilic

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/c60ed4ebccce