1966213 - Fall back to Glean client_info for crash.app_channel and crash.app_display_version

Status: RESOLVED FIXED

(Crash Pings :: Post-Processing, enhancement)

Description

[Alex Franchuk [:afranchuk]]

We use crash.app_channel and crash.app_display_version to select pings since https://github.com/mozilla/crash-ping-ingest/commit/3509549f86bcf80258352a6adc59ba6872c43fcd (as part of some rewriting of the SQL for bug 1959459), however per bug 1966210 the Java exceptions don't populate these fields. Just in case these metrics (or crash annotations which populate them) are missing, use the client_info for those values, as that should be close enough and it is more detrimental to exclude pings than it is to potentially attribute them to the wrong version (the volume of misattribution is likely to be very, very low, if existing at all).

Comment 1

[Alex Franchuk [:afranchuk]]

Ingest fixed in https://github.com/mozilla/crash-ping-ingest/commit/43dd6358d86dd68be3c6444a94ac434fb9889a14.

Comment 2

[Alex Franchuk [:afranchuk]]

Frontend fixed in https://github.com/mozilla/crash-pings/commit/8c5b7907a61dc143eea5f017fae151027e50e95b.

Comment 3

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1966213 - Document best practices and caveats for Glean client_info usage. r=gsvelto

Comment 4

[Alex Franchuk [:afranchuk]]

Remote settings fixed in https://github.com/mozilla/remote-settings-ondemand-crashes/commit/3995397617cdfffbbcc18a8624f015c79afd3a9c.

Comment 5

[Alex Franchuk [:afranchuk]]

The backfill of crash ping data (with fixed ingestion) is complete, and frontend caches are clearing now. There was some spam stuff from crawlers or otherwise in the caches, so it's taking a while to clear (I've since added some validation to prevent it, though ultimately it was just wasting tiny bits of space with empty responses).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/291866a2dde1
Document best practices and caveats for Glean client_info usage. r=gsvelto

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/291866a2dde1