1966276 - Round the scroll position and getBoundingClientRect().height before using them in scroll-initial-target-with-text-fragment-navigation-target.html

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

The test uses these values to compare with integer value (clientHeight). The test will fail with the patch for bug 1674687.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1966276 - Round getBoundingClientRect()'s height and Element.scrollTop to avoid mis-comparison between double values and integer values. r?emilio

The target element (top_box) height is defined by '60vh', the scroll
position also depends on vh-units values, thus these values would be
fractional on certain browser window sizes.

(It can be observable with the default headless mode browser window size,
1366x768.)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fa6a18a0800
Round getBoundingClientRect()'s height and Element.scrollTop to avoid mis-comparison between double values and integer values. r=emilio

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/52524 for changes under testing/web-platform/tests

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4fa6a18a0800

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot